Re: [PATCH v2 4/4] automation: add tools/tests jobs on the AMD Zen3+ runner too

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Sat, 15 Feb 2025, Marek Marczykowski-Górecki wrote:
> On Fri, Feb 14, 2025 at 04:33:07PM -0800, Stefano Stabellini wrote:
> > On Fri, 14 Feb 2025, Marek Marczykowski-Górecki wrote:
> > > Signed-off-by: Marek Marczykowski-Górecki 
> > > <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> > > ---
> > > new in v2
> > > If those tests are sensitive to underlying hardware, I guess it makes
> > > sense to run them on other runners too. Are they?
> > > Similarly - does it matter if dom0 is PV or PVH for those tests? If not,
> > > probably better to put just one of those jobs (PV?) to save CI
> > > time.
> > 
> > It should make a difference for the vpci test probably. I think we
> > should keep both a PV and a PVH test of it. I think it is less important
> > to run them on multiple runners, but it cannot hurt.
> > 
> > > ---
> > >  automation/gitlab-ci/test.yaml | 23 +++++++++++++++++++++++
> > >  1 file changed, 23 insertions(+)
> > > 
> > > diff --git a/automation/gitlab-ci/test.yaml 
> > > b/automation/gitlab-ci/test.yaml
> > > index 93632f1f9204..fc7663e3367a 100644
> > > --- a/automation/gitlab-ci/test.yaml
> > > +++ b/automation/gitlab-ci/test.yaml
> > > @@ -162,6 +162,7 @@
> > >      PCIDEV: "01:00.0"
> > >      PCIDEV_INTR: "MSI-X"
> > >      CONSOLE_OPTS: "console=com1 com1=115200,8n1,pci,msi"
> > > +    SUT_ADDR: test-11.testnet
> > >    tags:
> > >      - qubes-hw11
> > 
> > Is this a spurious change?
> 
> No, the SUT_ADDR variable is used by the test script to extract the
> junit xml file via network.

Ah yes, I only looked at the patch without the context.

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>