Re: [PATCH v2] xen/console: print Xen version via keyhandler

[Denis Mukhin <dmkhn@xxxxxxxxx>]

On Thursday, February 13th, 2025 at 1:10 AM, Jan Beulich <jbeulich@xxxxxxxx> 
wrote:

> 
> 
> On 13.02.2025 09:28, dmkhn@xxxxxxxxx wrote:
> 
> > --- a/xen/include/xen/version.h
> > +++ b/xen/include/xen/version.h
> > @@ -29,4 +29,7 @@ int xen_build_id_check(const Elf_Note *n, unsigned int 
> > n_sz,
> > static inline void xen_build_init(void) {};
> > #endif
> > 
> > +void xen_print_version(void);
> > +void xen_print_build_id(void);
> 
> 
> Hmm, I'm sorry, as I should have thought of this earlier already: What exactly
> is the significance of the xen_ prefixes here? We're in Xen sources after all.

I followed the rest of the code in version.{h,c} which has `xen_` prefixes.

I moved new definitions w/o prefix to xen/include/xen/lib.h where most
of the debug tracing facilities are declared in v3.

> 
> Jan

Thanks,
Denis