Re: [PATCH v4 for-4.20(?) 0/4] Add/enable stack protector

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 2/13/25 3:21 PM, Oleksii Kurochko wrote:

On 2/13/25 3:07 PM, Andrew Cooper wrote:

On 13/02/2025 1:54 pm, Volodymyr Babchuk wrote:

Hi Andrew,

Andrew Cooper <andrew.cooper3@xxxxxxxxxx> writes:

On 14/01/2025 4:25 am, Volodymyr Babchuk wrote:

Volodymyr Babchuk (4):
  common: remove -fno-stack-protector from EMBEDDED_EXTRA_CFLAGS
  xen: common: add ability to enable stack protector
  xen: arm: enable stack protector feature
  CHANGELOG.md: Mention stack-protector feature

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

There's one minor formatting error which can be fixed on commit.

~Andrew

Thanks for the review. I noticed that this series is not committed. Is
there anything else required from my side?

You need an ARM Ack on patch 3.  [EDIT], no you don't, my R-by is good
enough.

Andrew, why it is enough your R-by for patch 3? It seems like it is fully Arm related patch
and I expect to see Ack from Arm maintainers. Also, there is some comments from Julien.

> > And at this point at rc4, you'll need to persuade Oleksii to take it for
> > 4.20.
> >
> > Personally I think it's low risk and worthwhile to take for 4.20, and it
> > was technically completed in time - it just fell between the cracks.
> >       
> I think the same it's low risk patch series, so we can take it for 4.20:
>  Release-Acked-by: Oleksii Kurochko <olekskii.kurochko@xxxxxxxxx>
>
> Thanks.
>
> ~ Oleksii
> > ~Andrew
> >       
>