Re: [BUG?] Wrong RC reported during 'make install'

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 12 Feb 2025, Oleksii Kurochko wrote:
> Hello everyone,
> 
> During the installation of Xen on an ARM server machine from the source code,
> I found that the wrong release candidate (rc) is being used:
>   $ make install  
>     install -m0644 -p xen //boot/xen-4.20-rc  
>     install: cannot remove ‘//boot/xen-4.20-rc’: Permission denied  
>     make[1]: *** [Makefile:507: _install] Error 1
> My expectation is that it should be xen-4.20-rc4.
> 
> I'm not sure if this behavior is intentional or if users are expected to set
> the XEN_VENDORVERSION variable manually to ensure the correct release
> candidate number.
> 
> In my opinion, we should set the proper release candidate number after
> "xen-4.20-rc" automatically.
> 
> Does anyone have any thoughts or suggestions on how to resolve this issue?

Hi Oleksii,

I did a quick test and I see exactly the same on x86 as well. This patch
fixes it, but then it would need someone to update the RC number in
xen/Makefile every time a new RC is made.

---
xen: add RC version number to xen filename

Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>

commit 319ac724748f2f03a5cc6e9648c9151f519eaeac
diff --git a/xen/Makefile b/xen/Makefile
index 65b460e2b4..3b395e1ead 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -6,6 +6,7 @@ this-makefile := $(call lastword,$(MAKEFILE_LIST))
 # All other places this is stored (eg. compile.h) should be autogenerated.
 export XEN_VERSION       = 4
 export XEN_SUBVERSION    = 20
+export XEN_VENDORVERSION = 4
 export XEN_EXTRAVERSION ?= -rc$(XEN_VENDORVERSION)
 export XEN_FULLVERSION   = $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION)
 -include xen-version