[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Coding Style Review and Automation
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 11 Feb 2025 09:10:38 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5/VTmBFXkiCU8sGdGJliSOOGQggOqMN5zsgaJWC9meo=; b=tYnu68p/hBKSc1qMEsOjRncF2Y4DoRji5ExDpmnw3NkpHpDZBd07kt7i97FYlk2LhQlABB9xlt8eQT1ow7g58T19ck2NPpTyJXKzH2MCFd1oAxy3Vit+5/NmKa4Z10mGVMdpSGJx+l34CB+qb8H87+dfY5VxKFrbe0uRsckILTsN91BTeWRgu2ebA8jMMPW8R74hwXxVvt35SjfxXHIWmJ7eFBQUfUbvEqAjychrLk/FJODG9paUWmyjc/Z+yeQuRYdIBvCYUxb7JClQ1lNh/LYWZNIDEWIw2hGCUNVwzE7+shjtCyubWczCHDFNJilz8lcS5/29B7etyRaD4Q7cFQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5/VTmBFXkiCU8sGdGJliSOOGQggOqMN5zsgaJWC9meo=; b=XDXGxMq8ch6N8WCPmuKVyH6DP895Y4ptc5/IwBhYQZa8sCUGr9KB7hJdZtm8hZyjGEo6UBxsIN8NLgqvNHBpjmmIC9LDkM2QL0NKLX5GeDjPnGSPZSXPWZJeEkJQmnP14+H66yYhCXsRcIsxzKMFL7hPu+2uUlUCUCjSbU70x7afFwCTg6cUx4+/N6G5S9/DmaemK5K2n7l7e7gRDIyu3KzdCFCu5Qu0R3tdSrb2mUGIpxTOholLFhxM+813JWIZI3Ds+HXkJomhmyuzG0uOEJkaGPKl9p9iatlB+ERzko8tVhOPrpEnI2BdMmjN1OmQUelq46UKBdOV/kEUkjoKFA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=PUtFdrajjL/oNkUQCPD3fvKQZtrcMx362h7Mu9DezST0KAKQ+6vlUEHJY5VUZlqOk9K9RHmzosK/2Gg8O0LXq2/n4U1Zycf037OHajdSS7fT/fLZo0sKLmKEoptlPrODpNjzKbjrkLmc4lp3Yxx8MGLUYtoGN6XlYIwN7Ntg8ZL02I1W3zVyZ4ILQLTqod1oIkcKTqTkNiH4xals/QBgDsLkrrqodsh0+0nDGdFs05DvQ4kpPISQiPuwOzBgQttQb9v6MYq5TllITzzg+Ln4hXwMn7rbHPHI7RwwSfCjjYTCNkGXzSiLPWMycMy8Mu37LaQ9rMVqsb9pEn00JfsV0Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cdKDUk9GvtTLZMwkFp9+trb2aqQD9HkOX57wjpt+yLG8MrzHDZxYpKF/GELxG4gOY4cUMpXoKyYGOHr/HhNKPmovUcm4M09SkeEk2uGT9cxcDj8US7MeYsTMLLSpMq8CAzvaIf9CY1p9fSLtM7e4Foo6SullALGfmTOyX6S7cf/Y95cs6VerhwJZIoCMvO4PNHuVoy4j8dZoqEJRtr/Bw5PbyfQQ7faK93rf3Rq0GyFrwUHRuls8LWQ+dxe5optnty4rtPLMqD3y4inrdMp4203RV0IEE3pa5/FgvtEQG3937PoIusaWxJmuLywqowMlMl7Q+ZMRFJHEM3COsQvO1Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Tue, 11 Feb 2025 09:11:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbfAEPdB5iHtyhPUOv3RpqtR+ORbNBzx2AgAACc4A=
- Thread-topic: Coding Style Review and Automation
Hi Roger,
>>
>> 3) The size of the patch after applying clang-format is huge. Really.
>> Something
>> like 9 MB. Even if everyone agrees that the approach is good and we can
>> proceed
>> with it, it is highly unlikely anyone will be able to review it. Considering
>> that new patches are being added to the upstream during such a review, it may
>> also lead to new code style violations or require a new review of that huge
>> patch.
>
> I think this approach is difficult. It would likely introduce a lot
> of noise when using `git blame` (I know, it's just one extra jump,
> but...), plus would likely break every patch that we currently have
> in-flight.
I think we already discussed this in the past and having some churn was
accepted,
also about breaking existing patches, every change merged has the potential to
do
that, this one is more likely but it’s the game I guess?
>
>> 4) Which clang-format version should we set as the one used by Xen, so it is
>> easy for everyone to use it on their hosts?
>>
>> 5) You name it. I think many people in the community can name their points
>> for
>> and against clang-format.
>
> What are the parts of our coding style that clang-format cannot
> correctly represent? Could you make a list of what would need to
> change in Xen coding style for it to match perfectly what clang-format
> will check?
we already went through that route, there is no checker anywhere that matches
the Xen coding style perfectly, so it’s either we change the coding style or we
don’t proceed further with any automatic check
>
> Ideally the first step would be to prepare a patch to adjust the
> coding style so it's in line with what clang-format will do.
It’s easy to say that, but difficult to implement, if we could accept the
clang-format
rules it would be easier to adopt the configuration itself as coding style,
maybe
enhanced with some comments.
Cheers,
Luca
|
