Re: [PATCH for-4.20 1/3] RISCV/boot: Run constructors during setup

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 2/7/25 11:01 PM, Andrew Cooper wrote:

> Without this, RISC-V isn't running boot time selftests when they're compiled
> in.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> CC: Michal Orzel <michal.orzel@xxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
> https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1660821676
>
> For-4.20.  Boot selftests are new in 4.20, and work in each other
> archtiecture.
>     
LGTM:

Reviewed-By: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

Thanks.

~ Oleksii
    
> ---
>  xen/arch/riscv/setup.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
> index 38ca4f3baa1b..f2b6e684ac69 100644
> --- a/xen/arch/riscv/setup.c
> +++ b/xen/arch/riscv/setup.c
> @@ -109,6 +109,8 @@ void __init noreturn start_xen(unsigned long bootcpu_id,
>       */
>      system_state = SYS_STATE_boot;
>  
> +    init_constructors();
> +
>      if ( acpi_disabled )
>      {
>          printk("Booting using Device Tree\n");
>