Re: [PATCH] automation: enable UBSAN for debug tests

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 2/7/25 12:03 AM, Stefano Stabellini wrote:

> On Thu, 6 Feb 2025, Orzel, Michal wrote:
> > On 06/02/2025 03:37, Stefano Stabellini wrote:
> > > automation: enable UBSAN for debug tests
> > >
> > > Enable CONFIG_UBSAN and CONFIG_UBSAN_FATAL for the ARM64 and x86_64
> > > build jobs, with debug enabled, which are later used for Xen tests on
> > > QEMU and/or real hardware.
> > >
> > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> > >         
> > Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
> >       
> Thanks!
>
>
> > However, I do remember Julien being opposed to this approach in the past, mostly because he did not like
> > the idea of failing on first UB that can possibly hide next UBs (I don't see this as a problem because other
> > UBs will simply be found on the next pipeline or locally when testing the fix).
> >       
> That may have been a problem in the past, but it is no longer an issue
> now that the pipeline is fully operational with UBSAN enabled on both
> ARM and x86.
>
> Andrew also mentioned in chat that he supports enabling UBSAN in the
> pipeline as soon as possible.
>
> Since the pipeline remains green with UBSAN enabled and is not expected
> to suddenly go red before the release, I am requesting a release
> ack from Oleksii.
>     
Agree, enabling UBSAN support in the pipeline is a good idea, so:
  R-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>

~ Oleksii
> Cheers,
>
> Stefano
>