Re: [PATCH v3 03/12] VMX: drop vmcs_revision_id

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Feb 26, 2024 at 05:42:50PM +0100, Jan Beulich wrote:
> It's effectively redundant with vmx_basic_msr. For the #define
> replacement to work, struct vmcs_struct's respective field name also
> needs to change: Drop the not really meaningful "vmcs_" prefix from it.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> v2: New.
> 
> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> @@ -175,7 +175,7 @@ static DEFINE_PER_CPU(paddr_t, current_v
>  static DEFINE_PER_CPU(struct list_head, active_vmcs_list);
>  DEFINE_PER_CPU(bool, vmxon);
>  
> -static u32 vmcs_revision_id __read_mostly;
> +#define vmcs_revision_id (vmx_basic_msr & VMX_BASIC_REVISION_MASK)
>  u64 __read_mostly vmx_basic_msr;

__ro_after_init maybe while at it (and then uint64_t also)?

I would place the #define after the definition of vmx_basic_msr, but
that's just my taste.

Thanks, Roger.