[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/4] xen/cppc: get xen-required cppc perf caps data
- To: Penny Zheng <Penny.Zheng@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Wed, 15 Jan 2025 17:39:15 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qyh+kwTWXZitFLG254D8m7l/ECF0ZTZ2RmGeERoGQNU=; b=Q3lr4oGEORtD3sDU5c/rJS6Ny1+1Q+OrBNlR2Zq3TOwoSTyNQ9a+zpRKLey37Zc1b9LDwOBgneUyzw68Z2ORMxYmcLThyy3mV1UwcnYy9zlQ4NuapxxtN76FpMCY032o2CUStk/Lz65jBeDnfOEY51wE11IiQr4hAMZgxI7+p5QTLM4jQrvzGSKsht7j/TO33OzjXA715/yCR4hgfrvupuM8d98+btobjtLMofiKbJPKBnsqKOMjDeEle5zVyiG5usu9i+WJjX12G71XvnLfoAwCOzm8Cx7i5jtKDXzi8W2BerNAjfwQNoVK6/K+veoEdXXmymJfLk4WMGB77zFg+w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M4KC35UOV7Yz71w8Rkohp2rhCHRH+ERCdutMsqT0ukp6b7dJ8jYqLVLWbCauAdjlYiymlKGdENe9YNHoApIiXYbFU7J3Tf7m5gGCB7sxXt3F+gNJU3ABccl43Ypi1uTAGDh2ExpYpFlHk7ZkkNTpbqpAqt5korZi1EwVSxOm+ukryDo4tNUGmA7jCDvzKkX+8UuCKCu9Dv1KpRKQwvj+KKh9tOsFKyHnGlMOffY3HzPe2i08hPeuYlKa5QxrAjsH107vyrkhnFKzsrDKX0uZOkjSVC55FY6iLPVJAzcRigw5nMKyH9lZiIbuZJhA4h5zTbZnNBxGOQO51Ie250cWAA==
- Cc: Ray Huang <Ray.Huang@xxxxxxx>, Xenia Ragiadakou <Xenia.Ragiadakou@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>
- Delivery-date: Wed, 15 Jan 2025 22:39:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Penny,
On 2024-12-05 00:42, Penny Zheng wrote:
diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
index 13d6ff84a1e9..3a436591da07 100644
--- a/drivers/acpi/cppc_acpi.c
+++ b/drivers/acpi/cppc_acpi.c
+ if (!high || !low || !nom || !min_nonlinear)
+ pr_warn("CPPC: read zero cpc register value for Xen Processor
%d"
+ "highest_reg: %llu, lowest_reg: %llu"
+ "nominal_reg: %llu, lowest_non_linear_reg: %llu\n",
The string lacks separation before highest and nominal and the preceding
number. Also, I think it could probably be consolidated to:
pr_warn("zero register for Xen CPU %d highest: %llu"
" lowest: %llu nominal: %llu, non_linear: %llu\n,
pr_fmt is already "ACPI CPPC: ", and "_reg" doesn't add much value.
Regards,
Jason
|
