[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v1 03/11] xen/x86: introduce "cpufreq=amd-pstate" xen cmdline
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Wed, 15 Jan 2025 08:33:58 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Btj5LjQxhrhR8/qfl/ax6KRztoFP6CkgKvKhOv3tAfI=; b=driehf/hxvDhOhzS4kmxctiePN4h2A64Pcqmloq86Y62EX6rXAuxHNnszRF9u2O7Bsa1fh8pUM4I9CuD3ICcjJTXWk7L4scGHkVhuHLeSCGCFIuoUg7cHN2YwQTPNCoqLgBd/qYi7sTGu3xHGbhD0y2eg6uNgFOUThjPmumluy5EoYaBaO4JBdUwL7dSMU2Sb4vZjFU/OmGMuP6Xxblr2KScBg3zmxJCSoLa9cIPrI19wYZqt4di0HzPNxMusYQI48tdMXnL+ry+nAY+eg1zA/xftSghNmU+xQ4H5AinyLtwLo5L7hlcslCP3Rvf40MN2kNsa2/Ooh4SDkuNmorRDA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KNGq1jYmAJPfCpPkG7MGHWPDJ91q27EORSGzBhxKDu6uQnW8uiAksh0yKNanl1dUbPZ9a6kQM/44l60IauQhHH6xKWYPNm1O+125Iy2w8a+SRx5NWRvtcfs2KvJHVxePKPu/ahyaFSt8l/25F+1w0RLuE/NmYEVq+zhgiqj6p3v1CcndxAxUZp+2jeDx2hQpqzow66SMxzIRbZ6zhzY7JW6DkaWUOEhEb0WlCXdFt9PIgMF74LYTW47VF2aYTFB7F4AGadjFdptoL2+aCp8SlzbYTbUurP1CXfHhF4TR7NIZmlbdulAQAD1yf3i0U+P2wnXcTD2dg2x+0GI952F1yg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Stabellini, Stefano" <stefano.stabellini@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Ragiadakou, Xenia" <Xenia.Ragiadakou@xxxxxxx>, "Andryuk, Jason" <Jason.Andryuk@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 15 Jan 2025 08:34:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=2345f288-ffe9-442a-bbb2-449ebf3f8be9;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2025-01-15T08:33:14Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
- Thread-index: AQHbRVx5dnEd/G58t0eEMeNox50YY7MOb2uAgAksanCAACl1AIAAADlg
- Thread-topic: [PATCH v1 03/11] xen/x86: introduce "cpufreq=amd-pstate" xen cmdline
[AMD Official Use Only - AMD Internal Distribution Only]
Hi,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Wednesday, January 15, 2025 4:32 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Stabellini, Stefano <stefano.stabellini@xxxxxxx>; Huang, Ray
> <Ray.Huang@xxxxxxx>; Ragiadakou, Xenia <Xenia.Ragiadakou@xxxxxxx>;
> Andryuk, Jason <Jason.Andryuk@xxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1 03/11] xen/x86: introduce "cpufreq=amd-pstate" xen
> cmdline
>
> On 15.01.2025 09:18, Penny, Zheng wrote:
> >> -----Original Message-----
> >> From: Jan Beulich <jbeulich@xxxxxxxx>
> >> Sent: Thursday, January 9, 2025 5:59 PM
> >>
> >> On 03.12.2024 09:11, Penny Zheng wrote:
> >>> --- a/xen/arch/x86/platform_hypercall.c
> >>> +++ b/xen/arch/x86/platform_hypercall.c
> >>> @@ -574,6 +574,12 @@ ret_t do_platform_op(
> >>>
> >>> case XEN_PM_CPPC:
> >>> {
> >>> + if ( !(xen_processor_pmbits & XEN_PROCESSOR_PM_CPPC) )
> >>> + {
> >>> + ret = -ENOSYS;
> >>
> >> ENOSYS isn't appropriate for such a situation.
> >
> > I've mirrored the return value, so maybe -EINVAL is better?
>
> Generally most wrong uses of ENOSYS want replacing by EOPNOTSUPP.
Oh, understood.
>
> Jan
Many thanks,
Penny
|
