| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
 [PATCH v4 27/30] x86/tlb: Make __flush_tlb_local() noinstr-compliant
 
To: linux-kernel@xxxxxxxxxxxxxxx,	x86@xxxxxxxxxx,	virtualization@xxxxxxxxxxxxxxx,	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,	loongarch@xxxxxxxxxxxxxxx,	linux-riscv@xxxxxxxxxxxxxxxxxxx,	linux-perf-users@xxxxxxxxxxxxxxx,	xen-devel@xxxxxxxxxxxxxxxxxxxx,	kvm@xxxxxxxxxxxxxxx,	linux-arch@xxxxxxxxxxxxxxx,	rcu@xxxxxxxxxxxxxxx,	linux-hardening@xxxxxxxxxxxxxxx,	linux-mm@xxxxxxxxx,	linux-kselftest@xxxxxxxxxxxxxxx,	bpf@xxxxxxxxxxxxxxx,	bcm-kernel-feedback-list@xxxxxxxxxxxxFrom: Valentin Schneider <vschneid@xxxxxxxxxx>Date: Tue, 14 Jan 2025 18:51:40 +0100Cc: Juergen Gross <jgross@xxxxxxxx>,	Ajay Kaher <ajay.kaher@xxxxxxxxxxxx>,	Alexey Makhalov <alexey.amakhalov@xxxxxxxxxxxx>,	Russell King <linux@xxxxxxxxxxxxxxx>,	Catalin Marinas <catalin.marinas@xxxxxxx>,	Will Deacon <will@xxxxxxxxxx>,	Huacai Chen <chenhuacai@xxxxxxxxxx>,	WANG Xuerui <kernel@xxxxxxxxxx>,	Paul Walmsley <paul.walmsley@xxxxxxxxxx>,	Palmer Dabbelt <palmer@xxxxxxxxxxx>,	Albert Ou <aou@xxxxxxxxxxxxxxxxx>,	Thomas Gleixner <tglx@xxxxxxxxxxxxx>,	Ingo Molnar <mingo@xxxxxxxxxx>,	Borislav Petkov <bp@xxxxxxxxx>,	Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>,	"H. Peter Anvin" <hpa@xxxxxxxxx>,	Peter Zijlstra <peterz@xxxxxxxxxxxxx>,	Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>,	Namhyung Kim <namhyung@xxxxxxxxxx>,	Mark Rutland <mark.rutland@xxxxxxx>,	Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>,	Jiri Olsa <jolsa@xxxxxxxxxx>,	Ian Rogers <irogers@xxxxxxxxxx>,	Adrian Hunter <adrian.hunter@xxxxxxxxx>,	"Liang, Kan" <kan.liang@xxxxxxxxxxxxxxx>,	Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>,	Josh Poimboeuf <jpoimboe@xxxxxxxxxx>,	Pawan Gupta <pawan.kumar.gupta@xxxxxxxxxxxxxxx>,	Sean Christopherson <seanjc@xxxxxxxxxx>,	Paolo Bonzini <pbonzini@xxxxxxxxxx>,	Andy Lutomirski <luto@xxxxxxxxxx>,	Arnd Bergmann <arnd@xxxxxxxx>,	Frederic Weisbecker <frederic@xxxxxxxxxx>,	"Paul E. McKenney" <paulmck@xxxxxxxxxx>,	Jason Baron <jbaron@xxxxxxxxxx>,	Steven Rostedt <rostedt@xxxxxxxxxxx>,	Ard Biesheuvel <ardb@xxxxxxxxxx>,	Neeraj Upadhyay <neeraj.upadhyay@xxxxxxxxxx>,	Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>,	Josh Triplett <josh@xxxxxxxxxxxxxxxx>,	Boqun Feng <boqun.feng@xxxxxxxxx>,	Uladzislau Rezki <urezki@xxxxxxxxx>,	Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>,	Lai Jiangshan <jiangshanlai@xxxxxxxxx>,	Zqiang <qiang.zhang1211@xxxxxxxxx>,	Juri Lelli <juri.lelli@xxxxxxxxxx>,	Clark Williams <williams@xxxxxxxxxx>,	Yair Podemsky <ypodemsk@xxxxxxxxxx>,	Tomas Glozar <tglozar@xxxxxxxxxx>,	Vincent Guittot <vincent.guittot@xxxxxxxxxx>,	Dietmar Eggemann <dietmar.eggemann@xxxxxxx>,	Ben Segall <bsegall@xxxxxxxxxx>,	Mel Gorman <mgorman@xxxxxxx>,	Kees Cook <kees@xxxxxxxxxx>,	Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>,	Christoph Hellwig <hch@xxxxxxxxxxxxx>,	Shuah Khan <shuah@xxxxxxxxxx>,	Sami Tolvanen <samitolvanen@xxxxxxxxxx>,	Miguel Ojeda <ojeda@xxxxxxxxxx>,	Alice Ryhl <aliceryhl@xxxxxxxxxx>,	"Mike Rapoport (Microsoft)" <rppt@xxxxxxxxxx>,	Samuel Holland <samuel.holland@xxxxxxxxxx>,	Rong Xu <xur@xxxxxxxxxx>,	Nicolas Saenz Julienne <nsaenzju@xxxxxxxxxx>,	Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>,	Yosry Ahmed <yosryahmed@xxxxxxxxxx>,	"Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>,	"Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx>,	Jinghao Jia <jinghao7@xxxxxxxxxxxx>,	Luis Chamberlain <mcgrof@xxxxxxxxxx>,	Randy Dunlap <rdunlap@xxxxxxxxxxxxx>,	Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>Delivery-date: Tue, 14 Jan 2025 18:04:16 +0000List-id: Xen developer discussion <xen-devel.lists.xenproject.org> 
 Later patches will require issuing a __flush_tlb_all() from noinstr code.
This requires making both __flush_tlb_local() and __flush_tlb_global()
noinstr-compliant.
For __flush_tlb_local(), xen_flush_tlb() has already been made noinstr, so
it's just native_flush_tlb_global(), and simply __always_inline'ing
invalidate_user_asid() gets us there
Signed-off-by: Valentin Schneider <vschneid@xxxxxxxxxx>
---
 arch/x86/include/asm/paravirt.h | 2 +-
 arch/x86/mm/tlb.c               | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
index b3daee3d46677..0c0dd186c03e6 100644
--- a/arch/x86/include/asm/paravirt.h
+++ b/arch/x86/include/asm/paravirt.h
@@ -70,7 +70,7 @@ void native_flush_tlb_one_user(unsigned long addr);
 void native_flush_tlb_multi(const struct cpumask *cpumask,
                             const struct flush_tlb_info *info);
 
-static inline void __flush_tlb_local(void)
+static __always_inline void __flush_tlb_local(void)
 {
        PVOP_VCALL0(mmu.flush_tlb_user);
 }
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 2d2ab3e221f0c..18b40bbc2fa15 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -257,7 +257,7 @@ static void choose_new_asid(struct mm_struct *next, u64 
next_tlb_gen,
  *
  * See SWITCH_TO_USER_CR3.
  */
-static inline void invalidate_user_asid(u16 asid)
+static __always_inline void invalidate_user_asid(u16 asid)
 {
        /* There is no user ASID if address space separation is off */
        if (!IS_ENABLED(CONFIG_MITIGATION_PAGE_TABLE_ISOLATION))
@@ -1206,7 +1206,7 @@ STATIC_NOPV noinstr void native_flush_tlb_global(void)
 /*
  * Flush the entire current user mapping
  */
-STATIC_NOPV void native_flush_tlb_local(void)
+STATIC_NOPV noinstr void native_flush_tlb_local(void)
 {
        /*
         * Preemption or interrupts must be disabled to protect the access
-- 
2.43.0
 |