Re: [PATCH v2 2/2] automation/eclair: make Misra rule 20.7 blocking for x86 also

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 2025-01-14 12:22, Roger Pau Monné wrote:
> Hello Oleksii,
>
> This is in principle ready to go in now (I'm currently running a
> private Eclair scan to ensure the patch is still OK against current
> staging).  I would like to ask for a release Ack.
One nit below, which I overlooked initially

> Thanks, Roger.
>
> On Tue, Nov 26, 2024 at 10:35:08AM +0100, Roger Pau Monne wrote:
> > There are no violations left, make the rule globally blocking for both 
> > x86 and
> > ARM.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > ---
> >  automation/eclair_analysis/ECLAIR/tagging.ecl | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl 
> > b/automation/eclair_analysis/ECLAIR/tagging.ecl
> > index 755ea3271fc9..cb4e233e838d 100644
> > --- a/automation/eclair_analysis/ECLAIR/tagging.ecl
> > +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl
> > @@ -80,6 +80,7 @@ MC3R1.R20.2||
> >  MC3R1.R20.3||
> >  MC3R1.R20.4||
> >  MC3R1.R20.6||
> > +MC3R1.R20.7||
> >  MC3R1.R20.9||
> >  MC3R1.R20.11||
> >  MC3R1.R20.12||
> > @@ -116,7 +117,7 @@ if(string_equal(target,"x86_64"),
> >  )
this hunk will not apply because it uses MC3R1, rather than MC3R2. 
Should be an easy fix.
> >  if(string_equal(target,"arm64"),
> > -    
> > service_selector({"additional_clean_guidelines","MC3R1.R2.1||MC3R1.R5.3||MC3.R11.2||MC3R1.R16.6||MC3R1.R20.7"})
> > +    
> > service_selector({"additional_clean_guidelines","MC3R1.R2.1||MC3R1.R5.3||MC3.R11.2||MC3R1.R16.6"})
> >  )
here as well

> >  
> > -reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"}
> > --
> > 2.46.0
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253