Re: [PATCH v4] docs: fusa: Add dom0less domain configuration requirements

[Ayan Kumar Halder <ayankuma@xxxxxxx>]

On 09/01/2025 07:53, Bertrand Marquis wrote:
> Hi Ayan,
Hi Bertrand,
> This is a lot better.
> I just have some minor phrasing comments after.
>
> > On 8 Jan 2025, at 18:03, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> wrote:
> >
> > From: Michal Orzel <michal.orzel@xxxxxxx>
> >
> > Add requirements for dom0less domain creation.
> >
> > Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> > Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> > ---
> > Changes from -
> >
> > v1 - 1. As the dom0less domain creation requirements specifies the dt properties
> > for creating domains, it has been moved to product requirements. Product
> > requirements define the interface Xen exposes to other domains.
> >
> > 2. For the requirements which introduces new terms (like grant table, etc), I
> > have provided the definition as part of the comments.
> >
> > 3. Introduced new market requirements to specify that Xen can assign iomem and
> > irqs to domains.
> >
> > 4. The design requirements will be added later.
> >
> > v2 - 1. Rephrased the requirements as suggested.
> >
> > 2. Split the product requirements into arm64 specific and common.
> >
> > 3. The arm64 specific requirements have arm64_ prefixed to their tag names.
> >
> > 4. Grant table requirements have been dropped for now.
> >
> > 5. Added a market requirement to denote that Xen can support multiple 
> > schedulers.
> >
> > 6. Updated index.rst as we have a new file ie product-reqs/reqs.rst.
> >
> > V3 - 1. Removed duplicate mention for 'Rationale'.
> >
> > 2. Fixed some of the descriptions as per the review comments.
> >
> > docs/fusa/reqs/index.rst                   |   1 +
> > docs/fusa/reqs/market-reqs/reqs.rst        |  31 ++++
> > docs/fusa/reqs/product-reqs/arm64/reqs.rst | 128 ++++++++++++++++-
> > docs/fusa/reqs/product-reqs/reqs.rst       | 160 +++++++++++++++++++++
> > 4 files changed, 318 insertions(+), 2 deletions(-)
> > create mode 100644 docs/fusa/reqs/product-reqs/reqs.rst
> >
> > diff --git a/docs/fusa/reqs/index.rst b/docs/fusa/reqs/index.rst
> > index 8a4dae6fb2..1088a51d52 100644
> > --- a/docs/fusa/reqs/index.rst
> > +++ b/docs/fusa/reqs/index.rst
> > @@ -8,6 +8,7 @@ Requirements documentation
> >
> >     intro
> >     market-reqs/reqs
> > +   product-reqs/reqs
> >     product-reqs/arm64/reqs
> >     design-reqs/arm64/generic-timer
> >     design-reqs/arm64/sbsa-uart
> > diff --git a/docs/fusa/reqs/market-reqs/reqs.rst 
> > b/docs/fusa/reqs/market-reqs/reqs.rst
> > index f456788d96..39b2714237 100644
> > --- a/docs/fusa/reqs/market-reqs/reqs.rst
> > +++ b/docs/fusa/reqs/market-reqs/reqs.rst
> > @@ -47,3 +47,34 @@ Comments:
> >
> > Needs:
> >   - XenProd
> > +
> > +Static VM definition
> > +--------------------
> > +
> > +`XenMkt~static_vm_definition~1`
> > +
> > +Description:
> > +Xen shall support assigning peripherals to various domains.
> "various" here could be removed or replaced with "a domain" to be coherent with
> the phrasing after.
I agree
> > +
> > +Rationale:
> > +
> > +Comments:
> > +Peripheral implies an iomem (input output memory) and/or interrupts.
> > +
> > +Needs:
> > + - XenProd
> > +
> > +Multiple schedulers
> > +-------------------
> > +
> > +`XenMkt~multiple_schedulers~1`
> > +
> > +Description:
> > +Xen shall provide different ways of scheduling virtual cpus onto physical cpus.
> different here is a bit imprecise.
> how about:
> Xen shall have configurable scheduling strategies of virtual cpus onto physical 
> cpus.
looks fine to me.

Are you ok to give your R-b ? Then I can request Michal to fix them on 
commit.
- Ayan

> The rest looks good.
>
> Cheers
> Bertrand