[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] xen/arm: ffa: fix build with clang
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Wed, 8 Jan 2025 10:23:16 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tbCi9TE/1plTXrMEFllOGd7+VRgSmGpJFrC/Msrw+Ug=; b=Ut71Ag4fxH0cijYR/jqT5wlRwdugO6BAk6chL9KPw59m2KTauQgob0EisVUJFGNbKLjm9LRbqsSWkq7G2z7EdaF5NmPsgScvKdPlypLJ5piMxtLz8NfADaHi4AH32T9ahG+hPPrRWt4Qj3e5OWUw2zXcFaweiK2Jc3tPBBfKuJYdthNPJKikYQ3Nc1CItqh/yFQDl2BPH09D8rwBtgFYZwAaO95Un4qtTCYjMxwgCA5On6tDHUqpuX2cwZheS3VTIbQZCA1apTaqeG67aq5nAqHLFFEH66U+XBpLeel/fLImPrkN9KgSnbJjhxzckTslzi+LVAX6mfZCT+l8pdJyOA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y9KOpFLfoVHI2ly8VkpMXiONC7NOjXWlfgmlPRJ74X2yyACsh41KCZjWEKRfU+oNCQMhY9GlspoE3RdVxoi34a6HIq4DbYHQMHOoPsszi+sAp0TSj5H2a770Mr1KGFKiKPHBaePTtELUNW2YiwPUQ7eHhevsGch8rh3b7UqY2TG20J19bDSHIiPnJjO4tT17i7bzKeFmjpCFmlr/wruWHs08i/G6CuXe0XChSs4f/INmHNf5aseRhZkZy/n+Ayh2EGbBBYupRut7iIA3hxhG4HXiRfI5Zr03pSMLIdVP6bI8Cc7+8n049hnC1YExddPYGnVv1/S6fMyLicspBW3M1Q==
- Cc: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Wed, 08 Jan 2025 15:23:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Clang 16 reports:
In file included from arch/arm/tee/ffa.c:72:
arch/arm/tee/ffa_private.h:329:17: error: 'used' attribute ignored on a
non-definition declaration [-Werror,-Wignored-attributes]
extern uint32_t __ro_after_init ffa_fw_version;
^
Remove the attribute from the header to resolve this. The attribute in
ffa.c is the one the matters anyway.
Fixes: 2f9f240a5e87 ("xen/arm: ffa: Fine granular call support")
Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
---
It appears the variable ffa_fw_version is only used in ffa.c. Was there
any rationale for exporting the symbol in 2f9f240a5e87 ("xen/arm: ffa:
Fine granular call support")? If not, perhaps we ought to make it static
again and remove the declaration in the header.
---
xen/arch/arm/tee/ffa_private.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/tee/ffa_private.h b/xen/arch/arm/tee/ffa_private.h
index d441c0ca5598..05368d5a88d3 100644
--- a/xen/arch/arm/tee/ffa_private.h
+++ b/xen/arch/arm/tee/ffa_private.h
@@ -326,7 +326,7 @@ extern void *ffa_rx;
extern void *ffa_tx;
extern spinlock_t ffa_rx_buffer_lock;
extern spinlock_t ffa_tx_buffer_lock;
-extern uint32_t __ro_after_init ffa_fw_version;
+extern uint32_t ffa_fw_version;
extern DECLARE_BITMAP(ffa_fw_abi_supported, FFA_ABI_BITMAP_SIZE);
bool ffa_shm_domain_destroy(struct domain *d);
base-commit: 70f5a875becc9444a959830b10a361982c31a366
--
2.47.1
|
