[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] docs: fusa: Add dom0less domain configuration requirements
- To: Ayan Kumar Halder <ayankuma@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 8 Jan 2025 12:58:16 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Qj3dY96vrj9T/c4ZHoupqeofSh5WUv/P7+cweYoVtk=; b=JDL0QDC3iLkpgQBBwjKDWQL5tk5rdV5/tK8HpFPhsWujBULf9pCIVNX2uKOYBL0VJtpXHpD5DROY+VgZq7bkRbJ/LiPVzlw1a8L+ZdurCCu6D2N7sW4rAe43qwDh/VywblyqSC0k/KHXGrPouY7LWfQ5bEpiKeRu35cVIOVKJ5Pu0TCUgpo/ZMIMRgbjcwQm9XU8LVfJMZGbi5gAqz3LVAf/1E/7Ajcj/H0KNO5r/7g3xFzWDnc8AqR/gG/kj1xas1hLn1/k3mD5ce1mh7icX1myGnEh3COYTM7a+3hXQICoO/qIVHzQmYxKb62NM8mKVcRezkrCVLOUnAXJJKX24Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xhmUsOGrDisEeXyeSb375yDvnra2Ra9vezkXEk4kz85IPxUsU2sJ73yNxofflbWTIVf5QAqxRbFWz/uB30LgYwjn/WIBk3mp7Cfyxi1UazZKAK/5z+2XWkTWPG6vN7aUTiJhfAl7Q+gBEjvrzqxS3IIWFkHhEi4tWDgJpJA0R8E/UxmPtst5OK8lD1SRS0XhgHrDq3lfTxZ9K96eY39s05NpseRVCH1h//IkPsRIqulnB2ZIvAWhuAmHcV/8Fe/2+DdXL5JphPiOccMoYN6V2XA2AzZQ/YPxGkDVN3pp0cTDragzu8Ymtdrwv5JIguNo7yahbHESvLavdHbxj2e/nQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Artem Mygaiev <artem_mygaiev@xxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>
- Delivery-date: Wed, 08 Jan 2025 12:58:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHbUgS4JJcMvJVd5kOG9/I5q9pAibMMoCqAgABUqACAAAEOgA==
- Thread-topic: [PATCH v3] docs: fusa: Add dom0less domain configuration requirements
Hi Ayan,
> On 8 Jan 2025, at 13:54, Ayan Kumar Halder <ayankuma@xxxxxxx> wrote:
>
>
> On 08/01/2025 07:51, Bertrand Marquis wrote:
>> Hi Ayan,
>
> Hi Bertrand,
>
> I just need clarifications on the two points and then I can send v4.
>
> < snip>
>
>>> +Domain Creation And Runtime
>>> +===========================
>>> +
>>> +Kernel command line arguments
>>> +-----------------------------
>>> +
>>> +`XenProd~kernel_cmd_line_args~1`
>>> +
>>> +Description:
>>> +Xen shall pass kernel command line arguments to a domain via a device tree.
>> Would it make sense to say where the "command line" to pass is specified ?
>
> Yes, although I don't feel very strongly about it. Let me know if this sounds
> ok :-
>
> Xen shall pass kernel command line arguments to a domain via a device tree
> using the property "/chosen/xen,xen-bootargs".
In fact those can come from several places (xen command line in the case of
dom0, device tree or guest config) so maybe not the simplest to specify it.
Please ignore this comment.
>
> < snip>
>
>>> +
>>> +vCPUs
>>> +-----
>>> +
>>> +`XenProd~vcpus~1`
>>> +
>>> +Description:
>>> +A domain shall have a configurable number of virtual CPUs (1 to XX).
>> XX should be replaced with "the maximum number specified at compilation
>> in the configuration through CONFIG_MAX_CPUS" or something like that.
>
> Actually we are talking about virtual CPUS whereas CONFIG_MAX_CPUS refer to
> physical cpus.
>
> So, it should be GUEST_MAX_VCPUS (which is hardcoded to 128 in
> xen/include/public/arch-arm.h).
>
> Thus, s/XX/128
Right so you should say 128 here.
Cheers
Bertrand
>
> I agree with your other comments.
>
> - Ayan
>
>
|
