Re: [PATCH v2 32/35] x86/hvm: add debugging facility to NS8250 UART emulator

[Denis Mukhin <dmkhn@xxxxxxxxx>]

On Monday, December 16th, 2024 at 7:08 AM, Jan Beulich <jbeulich@xxxxxxxx> 
wrote:

>
>
> On 06.12.2024 05:42, Denis Mukhin via B4 Relay wrote:
>
> > +static void ns8250_keyhandler_init(void)
> > +{
> > + register_keyhandler('1', ns8250_keyhandler_show,
> > + "dump virtual NS8250 state", 0);
> > + register_keyhandler('2', ns8250_keyhandler_irq,
> > + "trigger IRQ from virtual NS8250", 0);
>
>
> Characters for key handlers are a pretty scarce resource. I'm afraid I
> wouldn't want to see this committed, even if it may be helpful during
> (initial) debugging. Even more so when both handlers only ever act on
> a single domain. Imo both want to be domctl-s instead.

re: keyhandler resource: yes, thank you, I understand that.
I did not know better way to add dev debugging; I hooked to 'q' handler
in v3. Triggering vUART interrupts - dropped.

So no keyhandlers in v3.

>
> Jan