Re: [PATCH v2 20/35] xen/console: introduce console_owner_domid()

[Denis Mukhin <dmkhn@xxxxxxxxx>]

On Tuesday, December 10th, 2024 at 11:28 PM, Jan Beulich <jbeulich@xxxxxxxx> 
wrote:

>
>
> On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote:
>
> > From: Denis Mukhin dmukhin@xxxxxxxx
> >
> > console_owner_domid() is introduced to obtain the "console owner" domain ID.
> >
> > The call is used in NS8250 emulator to identify the case when physical xen
> > console focus is owned by the domain w/ NS8250 emulator, in which case,
> > messages from guest OS are formatted w/o '(XEN)' prefix.
>
>
> Such messages ought to be processed through guest_printk(), which wants a
> domain pointer, not a domid_t anyway. Plus isn't that going to be
> current->domain anyway at the callsite, eliminating the need for such a
>
> helper altogether?

If the current domain is owning the physical console and printing, say, Linux
login prompt, there's no need to add "(XEN)" for every printout; adding 
timestamps
can be disabled from Xen command line.

>
> Jan