Re: [PATCH v2 09/35] x86/domain: print emulation_flags

[Denis Mukhin <dmkhn@xxxxxxxxx>]

On Tuesday, December 10th, 2024 at 5:30 AM, Jan Beulich <jbeulich@xxxxxxxx> 
wrote:

>
>
> On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote:
>
> > Print d->arch.emulation_flags on the console for better traceability while
> > debugging in-hypervisor hardware emulators.
>
>
> Personally I disagree with such extra printing. And that would in this case

I plumbed this printout into 'q' keyhandler which looks much better place
to host this printout.

> even apply if you used dprintk() or gdprintk(). However, if others support
> the idea, I don't mean to stand in the way. Just that ...
>
> > --- a/xen/arch/x86/domain.c
> > +++ b/xen/arch/x86/domain.c
> > @@ -818,11 +818,15 @@ int arch_domain_create(struct domain *d,
> >
> > if ( !emulation_flags_ok(d, emflags) )
> > {
> > - printk(XENLOG_G_ERR "d%d: Xen does not allow %s domain creation "
> > + printk(XENLOG_G_ERR "d%d: Xen does not allow %s %sdomain creation "
> > "with the current selection of emulators: %#x\n",
> > - d->domain_id, is_hvm_domain(d) ? "HVM" : "PV", emflags);
> > + d->domain_id,
>
>
> ... if already you touch this, please switch to %pd and also ...
>
> > + is_hvm_domain(d) ? "HVM" : "PV",
> > + is_hardware_domain(d) ? "(hardware) " : "",
> > + emflags);
> > return -EOPNOTSUPP;
> > }
> > + printk(XENLOG_G_INFO "d%d: emulation_flags %#x\n", d->domain_id, emflags);
>
>
> .. use that here.

Oh, that's nice! Thank you.
Fixed.

>
> Jan