Re: [PATCH v2 16/35] xen/console: introduce printk_common()

[Denis Mukhin <dmkhn@xxxxxxxxx>]

On Tuesday, December 10th, 2024 at 6:27 AM, Jan Beulich <jbeulich@xxxxxxxx> 
wrote:

>
>
> On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote:
>
> > Introduce new printk() variant for convenient printouts which skip '(XEN)'
> > prefix on xen console. This is needed for the case when physical console is
> > owned by a domain w/ in-hypervisor UART emulation enabled.
>
>
> Imo it should still be guest_printk() which is then used from there.

I ended up w/ printk_noprefix(): vprintk_common() expects user-defined prefix,
while original printk_common() does not expect prefix. Such inconsistency
may be confusing because both functions are named xxx_common().

>
> > --- a/xen/include/xen/lib.h
> > +++ b/xen/include/xen/lib.h
> > @@ -61,6 +61,9 @@ debugtrace_printk(const char *fmt, ...) {}
> > extern void printk(const char *fmt, ...)
> > attribute ((format (printf, 1, 2), cold));
> >
> > +extern void printk_common(const char *fmt, ...)
> > + attribute ((format (printf, 1, 2)));
>
>
> No "cold" attribute, compared to printk()?

Thanks, fixed.

>
> Jan