Re: [PATCH v2 10/35] xen/domain: add get_initial_domain_id()

[Denis Mukhin <dmkhn@xxxxxxxxx>]

On Tuesday, December 10th, 2024 at 5:50 AM, Jan Beulich <jbeulich@xxxxxxxx> 
wrote:

>
>
> On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote:
>
> > Move get_initial_domain_id() to a public API and enable for all 
> > architectures.
> > That is pre-requisite change for console focus switch logic cleanup.
>
>
> Yet then how does this fit with dom0less, let alone hyperlaunch,
> where multiple domains may be created right when Xen starts?

I see it now, thanks; fixed in v3.

>
> Plus, if you make this generic, shouldn't Arm also be adjusted to
> use this function (if nothing else then to avoid things going out
> of sync later on)?

Yes, Arm port should have been adjusted; thanks a lot!
Addressed.

>
> > @@ -2229,6 +2230,15 @@ int continue_hypercall_on_cpu(
> > return 0;
> > }
> >
> > +domid_t get_initial_domain_id(void)
> > +{
> > +#ifdef CONFIG_X86
> > + return pv_shim_initial_domain_id();
> > +#else
> > + return 0;
> > +#endif
> > +}
>
>
> Imo this either wants to use CONFIG_PV_SHIM instead, eliminating the
> need for the pv_shim_initial_domain_id() stub.

Fixed.

>
> Jan