Re: [PATCH v2 02/35] xen/irq: introduce NO_IRQ

[Denis Mukhin <dmkhn@xxxxxxxxxxxxxx>]

On Tuesday, December 10th, 2024 at 5:17 AM, Jan Beulich <jbeulich@xxxxxxxx> 
wrote:

>
>
> On 06.12.2024 05:41, Denis Mukhin via B4 Relay wrote:
>
> > From: Denis Mukhin dmukhin@xxxxxxxx
> >
> > Introduce definition for IRQ resource checks.
>
>
> How does this fit ...
>
> > --- a/xen/include/xen/irq.h
> > +++ b/xen/include/xen/irq.h
> > @@ -53,6 +53,7 @@ struct irqaction {
> > #define AUTO_ASSIGN_IRQ (-1)
> > #define NEVER_ASSIGN_IRQ (-2)
> > #define FREE_TO_ASSIGN_IRQ (-3)
> > +#define NO_IRQ (-4)
>
>
> ... the grouping here? The constants in context aren't used anywhere,
> so it's hard to see whether / how the new one fits here (and doesn't
> instead belong into the new resource.h you introduce in patch 1). Once
> again likely best to have this in the patch where it's first needed,
> thus providing at least some context.

I ended up dropping this change.

>
> Jan