Re: Linux 6.13-rc5 Xen HVM with PCI passthrough (USB controller) crash

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Marek,

On Fri, Jan 3, 2025 at 7:10 PM Marek Marczykowski-Górecki
<marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Jan 03, 2025 at 02:00:28AM +0000, Andrew Cooper wrote:
> > On 03/01/2025 12:42 am, Marek Marczykowski-Górecki wrote:
> > > On Fri, Jan 03, 2025 at 01:18:31AM +0100, Marek Marczykowski-Górecki 
> > > wrote:
> > >> On Thu, Jan 02, 2025 at 08:39:16PM +0100, Marek Marczykowski-Górecki 
> > >> wrote:
> > >>> On Thu, Jan 02, 2025 at 08:17:00PM +0100, Jürgen Groß wrote:
> > >>>> On 02.01.25 19:54, Marek Marczykowski-Górecki wrote:
> > >>>>> There is
> > >>>>> one issue (likely unrelated to this change) - sys-usb (HVM domU with 
> > >>>>> USB
> > >>>>> controllers passed through) crashes on a system with Raptor Lake CPU
> > >>>>> (only, others, including ADL and MTL look fine):
> > >> Correction, it does happen on some others too, just got the crash on the 
> > >> ADL
> > >> system, although looks a bit different ("Corrupted page table at ..."):
> > > I've collected some more of them at 
> > > https://github.com/QubesOS/qubes-issues/issues/9681
> > >
> > > Should I start new thread for this? On one hand, it's a different domain
> > > type (HVM), but on the other hand, many of the crashes are around
> > > loading modules too.
> >
> > https://lore.kernel.org/lkml/20241227072825.1288491-1-rppt@xxxxxxxxxx/T/#t
> > looks relevant.  Probably worth following up.
>
> As responded there, I don't think so, as that series is not part of
> 6.13-rc5. But in the meantime, I bisected it and got this commit:
>
> 5185e7f9f3bd754ab60680814afd714e2673ef88 is the first bad commit
> commit 5185e7f9f3bd754ab60680814afd714e2673ef88
> Author: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
> Date:   Wed Oct 23 19:27:11 2024 +0300
>
>     x86/module: enable ROX caches for module text on 64 bit
>
>     Enable execmem's cache of PMD_SIZE'ed pages mapped as ROX for module text
>     allocations on 64 bit.
>
>     Link: https://lkml.kernel.org/r/20241023162711.2579610-9-rppt@xxxxxxxxxx
>     Signed-off-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
>     Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
>     Tested-by: kdevops <kdevops@xxxxxxxxxxxxxxx>
>     Cc: Andreas Larsson <andreas@xxxxxxxxxxx>
>     Cc: Andy Lutomirski <luto@xxxxxxxxxx>
>     Cc: Ard Biesheuvel <ardb@xxxxxxxxxx>
>     Cc: Arnd Bergmann <arnd@xxxxxxxx>
>     Cc: Borislav Petkov (AMD) <bp@xxxxxxxxx>
>     Cc: Brian Cain <bcain@xxxxxxxxxxx>
>     Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
>     Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
>     Cc: Christoph Hellwig <hch@xxxxxx>
>     Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
>     Cc: Dinh Nguyen <dinguyen@xxxxxxxxxx>
>     Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>     Cc: Guo Ren <guoren@xxxxxxxxxx>
>     Cc: Helge Deller <deller@xxxxxx>
>     Cc: Huacai Chen <chenhuacai@xxxxxxxxxx>
>     Cc: Ingo Molnar <mingo@xxxxxxxxxx>
>     Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
>     Cc: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>
>     Cc: Kent Overstreet <kent.overstreet@xxxxxxxxx>
>     Cc: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
>     Cc: Mark Rutland <mark.rutland@xxxxxxx>
>     Cc: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
>     Cc: Matt Turner <mattst88@xxxxxxxxx>
>     Cc: Max Filippov <jcmvbkbc@xxxxxxxxx>
>     Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
>     Cc: Michal Simek <monstr@xxxxxxxxx>
>     Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
>     Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx>
>     Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>     Cc: Richard Weinberger <richard@xxxxxx>
>     Cc: Russell King <linux@xxxxxxxxxxxxxxx>
>     Cc: Song Liu <song@xxxxxxxxxx>
>     Cc: Stafford Horne <shorne@xxxxxxxxx>
>     Cc: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
>     Cc: Suren Baghdasaryan <surenb@xxxxxxxxxx>
>     Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
>     Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>     Cc: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
>     Cc: Vineet Gupta <vgupta@xxxxxxxxxx>
>     Cc: Will Deacon <will@xxxxxxxxxx>
>     Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>
>  arch/x86/Kconfig   |  1 +
>  arch/x86/mm/init.c | 37 ++++++++++++++++++++++++++++++++++++-
>  2 files changed, 37 insertions(+), 1 deletion(-)
>
> I'm extending CC...

Do you really think adding all non-Intel maintainers will help fixing
an Intel-specific problem? Please do not do that.
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds