Re: [XEN PATCH] eclair-analysis: Add usage of varargs extension for C99

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 2024-12-17 17:46, Andrew Cooper wrote:
> On 17/12/2024 4:45 pm, Jan Beulich wrote:
> > On 17.12.2024 17:40, Andrew Cooper wrote:
> > > On 17/12/2024 4:24 pm, Nicola Vetrini wrote:
> > > > This extension name is missing from the current list of extension 
> > > > used
> > > > by Xen, therefore is must be added to that configuration in order to
> > > > avoid violations for MISRA C Rule 1.1.
> > > >
> > > > Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> > > Given CI is broken, I've put this in for testing:
> > >
> > > https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1592826906
> > If this was fixing an earlier commit, shouldn't it come with a Fixes: 
> > tag
> > anyway?
> Yeah, it probably should have a Fixes, even if it is technically a
> combined one with also changing the runner.
I agree. I did forget putting a fixes tag, that was a bit rushed. We can 
unmark R1.1 and R2.1 temporarily and then respin this to properly 
address both rules.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)