[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0
- To: Ariel Otilibili-Anieli <Ariel.Otilibili-Anieli@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 16 Dec 2024 12:01:23 +0100
- Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Mon, 16 Dec 2024 11:01:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.12.2024 11:36, Ariel Otilibili-Anieli wrote:
> On Monday, December 16, 2024 10:53 CET, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
>> On 15.12.2024 16:40, Ariel Otilibili wrote:
>>> * iasl complains _HID and _ADR cannot be used at the same time
>>>
>>> ```
>>> /usr/bin/iasl -vs -p tools/firmware/hvmloader/dsdt_anycpu.tmp -tc
>>> tools/firmware/hvmloader/dsdt_anycpu.asl 2>&1 | grep -B10 HID
>>> tools/firmware/hvmloader/dsdt_anycpu.asl 40: Device (PCI0)
>>> Warning 3073 - Multiple types ^
>>> (Device object requires either a _HID or _ADR, but not both)
>>> ```
>>>
>>> * generally _HID devices are enumerated and have their drivers loaded by
>>> ACPI
>>> * this is from "ASL 2.0 Introduction and Overview" (page 4).
>>> * removing _ADR, the warning is cleared out.
>>
>> Okay, that's the positive aspect. Yet what about the potential fallout
>> thereof?
>> Can you confirm that there's no risk of regressions with older guest OSes,
>> for
>> example?
>
> OSes that were released after ACPI 2.0 should work [1]; including WinXP:
> The 2.0 specs says either _HID or _ADR should be included [2], not both
> (Section 6.1, page 146).
We must be looking at two different variants of the spec then. My copy says
"device object must contain either an _HID object or an _ADR object, but can
contain both." Also still in 2.0c. I agree that in e.g. 6.5 the wording has
changed. I also agree that the use of "either" doesn't help clarity.
> I chose WinXP because, on another patch, it came up in the discussion [3].
And indeed appropriately so.
Jan
|
