[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/11] misc: Use never-managed version of pci_intx()
 
- To: Bjorn Helgaas <helgaas@xxxxxxxxxx>
 
- From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
 
- Date: Fri, 13 Dec 2024 08:31:45 +0100
 
- Cc: Philipp Stanner <pstanner@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>,	Alex Dubov <oakad@xxxxxxxxx>, amien Le Moal <dlemoal@xxxxxxxxxx>,	Niklas Cassel <cassel@xxxxxxxxxx>,	Basavaraj Natikar <basavaraj.natikar@xxxxxxx>,	Jiri Kosina <jikos@xxxxxxxxxx>,	Benjamin Tissoires <bentiss@xxxxxxxxxx>,	Sudarsana Kalluru <skalluru@xxxxxxxxxxx>,	Manish Chopra <manishc@xxxxxxxxxxx>,	Andrew Lunn <andrew+netdev@xxxxxxx>,	"David S. Miller" <davem@xxxxxxxxxxxxx>,	Eric Dumazet <edumazet@xxxxxxxxxx>,	Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>,	Rasesh Mody <rmody@xxxxxxxxxxx>, GR-Linux-NIC-Dev@xxxxxxxxxxx,	Igor Mitsyanko <imitsyanko@xxxxxxxxxxxxx>,	Sergey Matyukevich <geomatsi@xxxxxxxxx>,	Kalle Valo <kvalo@xxxxxxxxxx>, Sanjay R Mehta <sanju.mehta@xxxxxxx>,	Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>,	Jon Mason <jdmason@xxxxxxxx>, Dave Jiang <dave.jiang@xxxxxxxxx>,	Allen Hubbe <allenbh@xxxxxxxxx>,	Bjorn Helgaas <bhelgaas@xxxxxxxxxx>,	Alex Williamson <alex.williamson@xxxxxxxxxx>,	Juergen Gross <jgross@xxxxxxxx>,	Stefano Stabellini <sstabellini@xxxxxxxxxx>,	Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>,	Mario Limonciello <mario.limonciello@xxxxxxx>,	Chen Ni <nichen@xxxxxxxxxxx>, Ricky Wu <ricky_wu@xxxxxxxxxxx>,	Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Breno Leitao <leitao@xxxxxxxxxx>,	Thomas Gleixner <tglx@xxxxxxxxxxxxx>,	Kevin Tian <kevin.tian@xxxxxxxxx>,	Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>,	Mostafa Saleh <smostafa@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>,	Yi Liu <yi.l.liu@xxxxxxxxx>, Kunwu Chan <chentao@xxxxxxxxxx>,	Dan Carpenter <dan.carpenter@xxxxxxxxxx>,	"Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>,	Ankit Agrawal <ankita@xxxxxxxxxx>,	Reinette Chatre <reinette.chatre@xxxxxxxxx>,	Eric Auger <eric.auger@xxxxxxxxxx>, Ye Bin <yebin10@xxxxxxxxxx>,	linux-ide@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,	linux-input@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx,	linux-wireless@xxxxxxxxxxxxxxx, ntb@xxxxxxxxxxxxxxx,	linux-pci@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx,	xen-devel@xxxxxxxxxxxxxxxxxxxx
 
- Delivery-date: Fri, 13 Dec 2024 07:32:45 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
On Thu, Dec 12, 2024 at 01:26:37PM -0600, Bjorn Helgaas wrote:
> [cc->to: Arnd, Greg, Alex]
> 
> On Mon, Dec 09, 2024 at 02:06:27PM +0100, Philipp Stanner wrote:
> > pci_intx() is a hybrid function which can sometimes be managed through
> > devres. To remove this hybrid nature from pci_intx(), it is necessary to
> > port users to either an always-managed or a never-managed version.
> > 
> > cardreader/rtsx_pcr.c and tifm_7xx1.c enable their PCI-Device with
> > pci_enable_device(). Thus, they need the never-managed version.
> > 
> > Replace pci_intx() with pci_intx_unmanaged().
> > 
> > Signed-off-by: Philipp Stanner <pstanner@xxxxxxxxxx>
> 
> Looking for ack from Arnd, Greg, Alex.
Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
 
 
    
     |