[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [QEMU PATCH v10] xen/passthrough: use gsi to map pirq when dom0 is PVH
- To: Anthony PERARD <anthony@xxxxxxxxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Fri, 13 Dec 2024 02:56:49 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CKOUlPpI6dtus3JgEj5ocRUYgdhISRnrB6EbG4Md3r8=; b=VxIAUsjMNWFdhKm3khnnG2DZHZOXhhNh/09/yrhoQ4KAS23vjrTArq8fB7GSjX6hL9FtYRG0IEQwkti39rRubre9ebo6eeyBKurzM3x8tXHV3+zV+GsubLfTmrj2vlXBuYoYjuaGz4mX7suAv9T3NxyZjOK/Vf59xY0my8SXnl63mEUBQ40bpQXyJ6+GQSQp0fOlsZlVFVzZq2ngVHTduMw6sfrBeDLxWzRXlrYL82kgrtstWh8WWVJ+S06Hrkg5CgtgRv7rEn36pQwcGUn94OLhmGwiux9WZxCKAjZGbGEGzQ27wN7mocfTqAtcv0hDaKUEUz6PmndeuPSPZt2HRQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PBdT/h7kcYcZeE+Z4oU2sWXMjEBbGtOmLypa0/3jNe46gw3SwF/9jwJOIwzLXdpGarKersPbXttzw/TXpNP27uIX3t585kZrZwnI3wULNd5SJKbmBlAHWjqf9fqqAQRXDnIrLNdjVzVLL+AWexPG6Su5pZhVpUsI5LYmIHVXvbkkDsHRtTbbZHU+O0d7V48w/9HmUJ9ZPBND/s3MSmcPKOuKQN7FSghU7LLfB32FqMR6xyYIkXX18y3GfABtL25ozi8pzMAr+SPc2qu6gkxFY2S89ply171tAw6ae/42cJ8vR0t2HTMooKBoXkQ6gy6Oh9KPuPPQHNxLD83NQZdzBA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, "Edgar E . Iglesias" <edgar.iglesias@xxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Fri, 13 Dec 2024 02:57:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbMBN9zgKXu6QHp0mudGAMtCr+w7K9RysAgCKFMICAAyspgIABQ32A
- Thread-topic: [QEMU PATCH v10] xen/passthrough: use gsi to map pirq when dom0 is PVH
On 2024/12/12 23:38, Anthony PERARD wrote:
> On Tue, Dec 10, 2024 at 07:17:30AM +0000, Chen, Jiqian wrote:
>> On 2024/11/19 00:05, Anthony PERARD wrote:
>>> On Wed, Nov 06, 2024 at 02:14:18PM +0800, Jiqian Chen wrote:
>>>> In PVH dom0, when passthrough a device to domU, QEMU code
>>>> xen_pt_realize->xc_physdev_map_pirq wants to use gsi, but in current codes
>>>> the gsi number is got from file /sys/bus/pci/devices/<sbdf>/irq, that is
>>>> wrong, because irq is not equal with gsi, they are in different spaces, so
>>>> pirq mapping fails.
>>>>
>>>> To solve above problem, use new interface of Xen, xc_pcidev_get_gsi to get
>>>> gsi and use xc_physdev_map_pirq_gsi to map pirq when dom0 is PVH.
>>>>
>>>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>>>> Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
>>>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>>>
>>> Acked-by: Anthony PERARD <anthony@xxxxxxxxxxxxxx>
>>>
>>> But, this following change probably needs an ack from PCI maintaners,
>>> CCed.
>> As PCI maintainers didn't response for weeks,
>> can I just move the definition of the macro back to xen_pt.c file ?
>
> No, that's fine. I should be able to send a pull-request with this
> change without too much trouble.
>
Thank you very much!
> Cheers,
>
--
Best regards,
Jiqian Chen.
|
