Re: [PATCH 15/15] x86/hyperlaunch: add capabilities to boot domain

["Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>]

On 11/25/24 19:09, Jason Andryuk wrote:
> On 2024-11-23 13:20, Daniel P. Smith wrote:
> > Introduce the ability to assign capabilities to a domain via its 
> > definition in
> > device tree. The first capability enabled to select is the control domain
> > capability. The capability property is a bitfield in both the device 
> > tree and
> > `struct boot_domain`.
> >
> > Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> > ---
> >   xen/arch/x86/domain_builder/core.c    |  2 +-
> >   xen/arch/x86/domain_builder/fdt.c     | 13 +++++++++++++
> >   xen/arch/x86/include/asm/bootdomain.h |  4 ++++
> >   xen/arch/x86/setup.c                  |  6 +++++-
> >   4 files changed, 23 insertions(+), 2 deletions(-)
> >
> > diff --git a/xen/arch/x86/domain_builder/core.c b/xen/arch/x86/ 
> > domain_builder/core.c
> > index 95cab06e6159..eaa019472724 100644
> > --- a/xen/arch/x86/domain_builder/core.c
> > +++ b/xen/arch/x86/domain_builder/core.c
> > @@ -93,9 +93,9 @@ void __init builder_init(struct boot_info *bi)
> >           i = first_boot_module_index(bi, BOOTMOD_UNKNOWN);
> >           bi->mods[i].type = BOOTMOD_KERNEL;
> >           bi->domains[0].kernel = &bi->mods[i];
> > +        bi->domains[0].capabilities |= BUILD_CAPS_CONTROL;
> >           bi->nr_domains = 1;
> >       }
> > -
> This will get cleaned up earlier.
>
> With that:
>
> Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Thanks!