[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/15] x86/hyperlaunch: specify dom0 mode with device tree
 
- To: Jan Beulich <jbeulich@xxxxxxxx>
 
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
 
- Date: Wed, 11 Dec 2024 12:48:12 -0500
 
- Arc-authentication-results: i=1; mx.zohomail.com;	dkim=pass  header.i=apertussolutions.com;	spf=pass  smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx;	dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
 
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 	t=1733939297; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; 	bh=YGNri/AxMCHpfyBgHH9l/zMoenKe3yZTJZzLs9MsvJA=; 	b=ds58Qr/u4bgXuCQxJrFpWMdHzjsEw52GWCjuwSDTd8hqnRV0fAulGofN7aGinAWhN2dV7TwQSYedSvsltBbCdv7DSdj+2mOZWpIHWhRPfv6Ndh1ZYtmrVBn4+eTlwydQ8mSd0q8+CBS9a8YdCJKI8Bt9pMnVtnorOqbD/iKpyyY=
 
- Arc-seal: i=1; a=rsa-sha256; t=1733939297; cv=none; 	d=zohomail.com; s=zohoarc; 	b=EbaxsIhDZ0T8EveJeM9QHEFjURLIVN23qWPyYnklrTdW5hZX1KuwerHri4GRfr60U+KQmOezIikIPrLObgxG61wDmsswOewBq1C5nLOXdjEraJr3NZtYTMZYsSN0yKoN9tICvD6Z/EphN5ZI71eyBQoYYG3Irg4kXiwBYjuHUu8=
 
- Cc: jason.andryuk@xxxxxxx, christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
 
- Delivery-date: Wed, 11 Dec 2024 17:48:29 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
On 12/2/24 07:06, Jan Beulich wrote:
 
On 23.11.2024 19:20, Daniel P. Smith wrote:
 
--- a/xen/arch/x86/domain_builder/fdt.c
+++ b/xen/arch/x86/domain_builder/fdt.c
@@ -141,6 +141,25 @@ static int __init process_domain_node(
              bd->domid = (domid_t)val;
              printk("  domid: %d\n", bd->domid);
          }
+        if ( match_fdt_property(fdt, prop, "mode" ) )
+        {
+            if ( fdt_prop_as_u32(prop, &bd->mode) != 0 )
+            {
+                printk("  failed processing mode for domain %s\n",
+                       name == NULL ? "unknown" : name);
+                return -EINVAL;
+            }
+
+            printk("  mode: ");
+            if ( !(bd->mode & BUILD_MODE_PARAVIRT) ) {
+                if ( bd->mode & BUILD_MODE_ENABLE_DM )
+                    printk("HVM\n");
+                else
+                    printk("PVH\n");
+            }
+            else
+                printk("PV\n");
 
Oh, and: What about BUILD_MODE_ENABLE_DM also being set here?
 
 
 Are you asking in the sense that the PV domain is being flag as a device 
model domain? Maybe I am missing something, but I am not aware of 
anything specific that must be set for a PV domain to operate as device 
model domain. If flask is in play, then there is a secure label 
requirement but that is separate of a mode that the domain must be 
running in. Please enlighten me if I am over looking something.
v/r,
dps
 
 
    
     |