[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/15] x86/hyperlaunch: add domain id parsing to domain config


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Wed, 11 Dec 2024 11:07:19 -0500
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1733933244; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=9Lm5ZvZ63BzudbCXPyhXRSASFrTO/SYhQw6yp/5HMXc=; b=O2iIBnvNl+NKCQ/KXMsLHOOvi4EUmpzwF52ZDPgBG5l6KurgEHkMYa/w8k2puMRnRjKNYgOfiPJ7k4W3BndaiIX3DLaoaA7jhIvEGW5d7LuwU+WG/jR31OXGxc0YX6PC0xjPsnXMegIAuYKWynto5IyM0xGUAyhl7CdeX6son/U=
  • Arc-seal: i=1; a=rsa-sha256; t=1733933244; cv=none; d=zohomail.com; s=zohoarc; b=OIdgTLlRBamAk5x8zqa5YxDgzhIzonsQLTB9tGDZSkEb3Qd8ML/+eUz95apsgeqPcufcuJ2at9spZTsjlRmP3GMaFFizq93tALo756GV1AN9I+MEJgFjWPecOgHcpqvz9ew7d+HgTPoRDsGSn6nfLOS52YBAAinN/usd0uL+X6w=
  • Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 11 Dec 2024 16:07:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12/2/24 07:00, Jan Beulich wrote:
On 26.11.2024 00:45, Jason Andryuk wrote:
On 2024-11-23 13:20, Daniel P. Smith wrote:
@@ -186,6 +209,12 @@ static int __init process_domain_node(
           return -EFAULT;
       }
+ if ( bd->domid == DOMID_INVALID )
+        bd->domid = get_initial_domain_id();
+    else
+        if ( bd->domid != get_initial_domain_id() )

single line "else if"?

Yes.

Agreed.

+            printk(XENLOG_WARNING "WARN: unsuported booting not using initial 
domid\n");

"unsupported"

Maybe "Booting without initial domid not supported"?

Plus the line then wants splitting after XENLOG_WARNING.

Okay.

v/r,
dps




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.