Re: [PATCH 05/15] kconfig: introduce domain builder config option

["Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>]

On 11/25/24 12:55, Jason Andryuk wrote:
> On 2024-11-23 13:20, Daniel P. Smith wrote:
> > Hyperlaunch domain builder will be the consolidated boot time domain 
> > building
> > logic framework. Introduces the config option to enable this domain 
> > builder to
> > and turn on the ability to load the domain configuration via a 
> > flattened device
> "to and"?
>
> > tree.
> Maybe:
> "Hyperlaunch is the boot time domain building framework where domain 
> configuration is loaded via a flattened device tree.  Introduce a 
> kconfig variable to control the feature."
Sure.

> > Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> > diff --git a/xen/arch/x86/domain_builder/Kconfig b/xen/arch/x86/ 
> > domain_builder/Kconfig
> > new file mode 100644
> > index 000000000000..7be2ec3ed00f
> > --- /dev/null
> > +++ b/xen/arch/x86/domain_builder/Kconfig
> > @@ -0,0 +1,15 @@
> > +
> > +menu "Domain Builder Features"
> > +
> > +config DOMAIN_BUILDER
> > +    bool "Domain builder (UNSUPPORTED)" if UNSUPPORTED
> > +    select LIB_DEVICE_TREE
> > +    help
> > +      Enables the domain builder capability to configure boot domain
> Indent is off.
ack

> > +      construction using a flattened device tree.
> > +
> > +      This feature is currently experimental.
> Does this need to be unsupported and experimental?  What makes this more 
> experimental and/or unsupported than any other new feature?
I don't believe it is a unilateral decision I get to make. In fact, with 
the directory introduction, a new HYPERLAUNCH section in MAINTAINERS 
might be warranted with this commit. If so, I would think myself, 
Christopher, and the x86 maintainers would all be set as maintainers for 
the feature.
> At least with the commit message and indent fixes:
>
> Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
thanks!

v/r,
dps