[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3 18/19] livepatch: Convert timeouts to secs_to_jiffies()



Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
secs_to_jiffies(). As the value here is a multiple of 1000, use
secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication.

This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
the following Coccinelle rules:

@@ constant C; @@

- msecs_to_jiffies(C * 1000)
+ secs_to_jiffies(C)

@@ constant C; @@

- msecs_to_jiffies(C * MSEC_PER_SEC)
+ secs_to_jiffies(C)

Signed-off-by: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx>
---
 samples/livepatch/livepatch-callbacks-busymod.c |  3 +--
 samples/livepatch/livepatch-shadow-fix1.c       |  3 +--
 samples/livepatch/livepatch-shadow-mod.c        | 15 +++++----------
 3 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/samples/livepatch/livepatch-callbacks-busymod.c 
b/samples/livepatch/livepatch-callbacks-busymod.c
index 
378e2d40271a9717d09eff51d3d3612c679736fc..69105596e72e6826aa2815cb2599eea56a0055ba
 100644
--- a/samples/livepatch/livepatch-callbacks-busymod.c
+++ b/samples/livepatch/livepatch-callbacks-busymod.c
@@ -44,8 +44,7 @@ static void busymod_work_func(struct work_struct *work)
 static int livepatch_callbacks_mod_init(void)
 {
        pr_info("%s\n", __func__);
-       schedule_delayed_work(&work,
-               msecs_to_jiffies(1000 * 0));
+       schedule_delayed_work(&work, 0);
        return 0;
 }
 
diff --git a/samples/livepatch/livepatch-shadow-fix1.c 
b/samples/livepatch/livepatch-shadow-fix1.c
index 
6701641bf12d454a770e49abeeb0dea92560e55e..f3f153895d6ce751fc91ae1224d91b220cba3e37
 100644
--- a/samples/livepatch/livepatch-shadow-fix1.c
+++ b/samples/livepatch/livepatch-shadow-fix1.c
@@ -72,8 +72,7 @@ static struct dummy *livepatch_fix1_dummy_alloc(void)
        if (!d)
                return NULL;
 
-       d->jiffies_expire = jiffies +
-               msecs_to_jiffies(1000 * EXPIRE_PERIOD);
+       d->jiffies_expire = jiffies + secs_to_jiffies(EXPIRE_PERIOD);
 
        /*
         * Patch: save the extra memory location into a SV_LEAK shadow
diff --git a/samples/livepatch/livepatch-shadow-mod.c 
b/samples/livepatch/livepatch-shadow-mod.c
index 
7e753b0d2fa611524c9e2adbe02c8fa3e9b6015e..5d83ad5a8118dbbac897dfcbb92e6d5f399d1dc3
 100644
--- a/samples/livepatch/livepatch-shadow-mod.c
+++ b/samples/livepatch/livepatch-shadow-mod.c
@@ -101,8 +101,7 @@ static __used noinline struct dummy *dummy_alloc(void)
        if (!d)
                return NULL;
 
-       d->jiffies_expire = jiffies +
-               msecs_to_jiffies(1000 * EXPIRE_PERIOD);
+       d->jiffies_expire = jiffies + secs_to_jiffies(EXPIRE_PERIOD);
 
        /* Oops, forgot to save leak! */
        leak = kzalloc(sizeof(*leak), GFP_KERNEL);
@@ -152,8 +151,7 @@ static void alloc_work_func(struct work_struct *work)
        list_add(&d->list, &dummy_list);
        mutex_unlock(&dummy_list_mutex);
 
-       schedule_delayed_work(&alloc_dwork,
-               msecs_to_jiffies(1000 * ALLOC_PERIOD));
+       schedule_delayed_work(&alloc_dwork, secs_to_jiffies(ALLOC_PERIOD));
 }
 
 /*
@@ -184,16 +182,13 @@ static void cleanup_work_func(struct work_struct *work)
        }
        mutex_unlock(&dummy_list_mutex);
 
-       schedule_delayed_work(&cleanup_dwork,
-               msecs_to_jiffies(1000 * CLEANUP_PERIOD));
+       schedule_delayed_work(&cleanup_dwork, secs_to_jiffies(CLEANUP_PERIOD));
 }
 
 static int livepatch_shadow_mod_init(void)
 {
-       schedule_delayed_work(&alloc_dwork,
-               msecs_to_jiffies(1000 * ALLOC_PERIOD));
-       schedule_delayed_work(&cleanup_dwork,
-               msecs_to_jiffies(1000 * CLEANUP_PERIOD));
+       schedule_delayed_work(&alloc_dwork, secs_to_jiffies(ALLOC_PERIOD));
+       schedule_delayed_work(&cleanup_dwork, secs_to_jiffies(CLEANUP_PERIOD));
 
        return 0;
 }

-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.