Re: [PATCH] x86/FPU: make vcpu_reset_fpu() build again with old gcc

[Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>]

On Tue, Dec 10, 2024 at 4:14 PM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 10.12.2024 16:12, Alejandro Vallejo wrote:
> > On Tue Dec 10, 2024 at 2:34 PM GMT, Jan Beulich wrote:
> >> On 10.12.2024 15:25, Alejandro Vallejo wrote:
> >>> On Mon Dec 9, 2024 at 3:13 PM GMT, Jan Beulich wrote:
> >>>> Fields of anonymous structs/unions may not be part of an initializer for
> >>>> rather old gcc.
> >>>
> >>> Can you add the specific version for tracking purposes?
> >>
> >> It's all the same as before, and I really didn't want to waste time on
> >> once again figuring out which exact version it was that the behavior
> >> changed to the better.
> >
> > Just checked on Godbolt. 4.7.1 works and 4.6.4 doesn't. Adding that data 
> > point
> > to the commit message really helps when navigating git-blame, even if it's 
> > not
> > as precise as it could be. Particularly if one wants to understand exactly
> > which quirk of which version of which compiler is being dealt with.
>
> Well, thanks for sorting that out. I've added that info.
>
> > With the commit message adjusted with the offending GCC version (i.e: 
> > <4.7.1):
> >
> >   Acked-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
>
> Thanks here as well. Any chance though you would be willing to upgrade that
> to R-b? Only that would allow me to put in the patch without waiting for yet
> another tag.
>
> Jan

Sure.

  Reviewed-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>

Cheers,
Alejandro