[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v11 02/12] xen/arm: add initial support for LLC coloring on arm64


  • To: Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Thu, 5 Dec 2024 09:04:22 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=minervasys.tech smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=94FhIpQYUlFz6e+5J4tHOh3JLjJ47tKls1jUrXSf6bM=; b=TUhjGSxaFtW+6RpNWpGS7Q6ewGmQ7xHZ53wV1IU8jSmfe+looWKe/2Gt4poaSkWT88q6ID3t+gP4ub9afEJpNanV6Ttq1UI4THWjeLhk5w1+gf1pQ+5wsoviK5CHInDu/zsZXXA8dc8RvKwQnF8NEd3LJcfnzCSU+SoigxNDfk3W56NhfWD+xhOvYLLQmhZbgNVQFzJYNqHsdFCVa4Mmusr4SqlUJVjBM+TQqJLUrFb1M3+p5bS5fnrAvPHtCI2QUjX8zfuya4fEbIAdExhAw6e5IhfYX9A1QJLJul0Q1WqsNxuV5DtjiPisUgbhSJB/3wymDZUlaigIkI+c2Pu6XA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d+DuXWGwAyDLLzb3K4J9ilEqWqWHFLT3LsNQV7QgxTX9ZCNkR533YTN5Z21JZNQc9CHKiKpjvdD2FGeuADqr7QgaTCGfBtmtZkmPo44Qkle8eEIjirHKDrWA+5/PSHmD9YPMikdc9hOTuiW9BvV0lNLTdBtWQkb04eTcnThoCTnLIPZtT3bAIvH/eOMnQjefFRHSiwBRJDHiJ9+F49RyH9NwKuQ423c+rLIpkyjTd78HQ/Yp7nqTSrB1cygVGa9GG1OZyTCzEUC8kLNNuAWMvobdM02m49E/SDyIf4e6darQ4WGzsxFJeRJrENbtSofWIRviz8ci2uomjhOYgF+7aA==
  • Cc: <andrea.bastoni@xxxxxxxxxxxxxxx>, <marco.solieri@xxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Bertrand Marquis" <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Thu, 05 Dec 2024 08:04:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 02/12/2024 17:59, Carlo Nonato wrote:
> 
> 
> LLC coloring needs to know the last level cache layout in order to make the
> best use of it. This can be probed by inspecting the CLIDR_EL1 register,
> so the Last Level is defined as the last level visible by this register.
> Note that this excludes system caches in some platforms.
> 
> Static memory allocation and cache coloring are incompatible because static
> memory can't be guaranteed to use only colors assigned to the domain.
> Panic during DomUs creation when both are enabled.
> 
> Based on original work from: Luca Miccio <lucmiccio@xxxxxxxxx>
> 
> Signed-off-by: Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>
> Signed-off-by: Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
[...]

> +    isb();
Attempt to build this patch with LLC_COLORING=y results in:
error: implicit declaration of function 'isb'

You need to include <asm/system.h>

Please, always try to make sure that each patch can be built successfully.

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.