[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/4] xen: common: add ability to enable stack protector
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Thu, 5 Dec 2024 03:34:54 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BrsBh4e8GRaB9i/ixGAlg5QXPFJibfasQBHxP1XHJcU=; b=YjvyrZ7vYXrlpXTE5MxHu9RyeHK+NbRXj7QXl0dc/2/gFW9GIPDqKb8XbGFNbZ3NLSrWM5LgY210eMclDWjsEaz5lgSgOfn1pFHliJgYeNlKtzd1M5X+4Od/Mktrg2xbGxwQjG7tESZGAK5so39Lz/VamwteenxeioJdTeqcMt5X+C/74T3SHdU6isGvSRcKAwd3jfll1U5fTZZpbA5IXA2d9NFB9WGWTM0szypVYSETW59icg7Gk8yWJQX3TXbzm+nJSRHVz4mpqZ7t6STlChHwTtUoKB+Nd2KUfTbudfdSemOz+qjrSCysvLvI9jXrxMuHpC4sYuVa3eSUnPA39w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r8YGHhnVzx2Z/DKT9KMizrBdj1nPKn+LalrtmZqrJWNMVLcrVCgDIHTkQesUo2T8o/n8OCBr/J5aMHNSCoDb/mj/TSTWTYrGW68AixTVQtqpJERMdcc1zjVRKC0K5OgnyKiGv4pmCxpBN8stTl3bw5/aOws6SNEihyzZ/blMnL/FA0v0DA4Ly7+1hfT1o1QT66xi0HsNTeR9K6CF+hzi6UzwMTiy8SYplF4Gme3uNk7+LXKYBZKJngIThMysOw9ExuLW0VSu5YwcyHz/D9Cf/gU6R7MtuuXjWFWYDzMhO0akXRTPRiKi9Nk9M2fOgkOnGbXdoxnNkQTkPhMQWlXB0g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 05 Dec 2024 03:35:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbQsSdkWILXIuO706XPyPrUU1cAA==
- Thread-topic: [PATCH v2 2/4] xen: common: add ability to enable stack protector
Hi Andrew,
I addressed almost all your comments, but didn't get this one:
Andrew Cooper <andrew.cooper3@xxxxxxxxxx> writes:
> On 30/11/2024 1:10 am, Volodymyr Babchuk wrote:
[...]
>> diff --git a/xen/common/stack-protector.c b/xen/common/stack-protector.c
>> new file mode 100644
>> index 0000000000..b258590d3a
>> --- /dev/null
>> +++ b/xen/common/stack-protector.c
>> @@ -0,0 +1,10 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +#include <xen/lib.h>
>> +#include <xen/random.h>
>> +
>> +unsigned long __ro_after_init __stack_chk_guard;
>> +
>> +void __stack_chk_fail(void)
>
> asmlinkage. This MISRA check is now blocking in Eclair.
I can see what we might want to mark it as "noreturn", but I don't
understand why you want to use asmlinkage. It is not called from
assembly.
--
WBR, Volodymyr
|
