[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] bootfdt: Add missing trailing commas in BOOTINFO_{ACPI,SHMEM}_INIT
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 3 Dec 2024 09:26:22 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Y6GPGf96UhUOpaZ7qfGW1EE/OhDxl3YJTjTOPLRSH4=; b=krp71+rRRI/AuvwFAdKA+NfYw9K+WsbVgQ4QHX9l2aQSMayO5mV91MC2m5cvQ3aZzkUjRIi5mupLkSN7vcVq363OxBbUfKjShYxXpPQ2wGqq+hvkLasmxfTwgXTFmHBonw5h2USTM/WaCnSZd+trZAcm/ITiugCOF8vlS3eWzcuPBfMbwWG7+rV/tpAIgSzOjz056pXoq5WXSO5nCrJ2dVGt6WFwIwmUjNsD7g8nsgHdpBv0p/JPzmliLcRWfUddWGdCwbkJ27YHEQs3os1Cm7lfnZw9NERA2vKeXpBV5SpGfhJRp7W/uEdtP8cBIHlPNmmMN0sHlezN6omeh3Q+8w==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Y6GPGf96UhUOpaZ7qfGW1EE/OhDxl3YJTjTOPLRSH4=; b=hHeEFQEmlSdhiKnBvYBD78hiB4AcxwPK1YizuGqINuJPhMh8RfjKjm5qv52RMrfq2upDLy37iIlkyJ39tIVtF1F2qX1Bc7jarI3GNPg9jeGSvO5BF/OVeIYDqsCvnmQDC2nGbpr3jzAOPB2R3bbSLhYWOblQwhuR1A3rH+Z3mose4NYRybLdyzX+df/5HPdp+wxW2mJ/GGorjkPfmCd1Rl+ki0vA9P0uGGLrHvBXQL957GAZUzcrPCPb5Bp3/q9RXzW9v5/actFaxZbf47SU5U2ZLGBZQ0LbJPBYi13IqcERiwcShR8zfOvKbHNyknCWteqpF9n1JkaOrQ5i5HlIFg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=D+c0cGlabbZIMaFTKhsVoQTjX4hcHss9LvPvkvMUiHANpvzf50xRw/IBBIkQYAbqNReCB3/JZKk/8g+otUosPNIaGHoyfENXmMrKATRtv9VtaCJHw24W4m4W/cavZjToyWv3OwrEyIOl4AohH8Jvr5otCdR0JwEH1sK5w0n0TvG6LCmLeozspkJ7dvRMoJvHi0XbMnLwes1pwAmFyDCdQtOWiex2lff1EbKQ0cJHd+W01p9L1xOlLmM1f2p4rrmev+3Fs1tYv0bcqtTGR2LJJCq6YucXLYjTX3DY8rJe7F/U0TdHA7+wYEgOGLToFJkQKqdsn2XeWlg2h4FxYA1CGg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tKaMLB1oLm9v3TodGjdQbIJp2jdT6GpieAapBgBzWTAP98nSV37sICrah8JwgNr5Oz/faA9fgWE9YXWiyrFxm9TN31mu2ZExl9JBql+A5s84Db666R5DJUxE4CIyQUiuZX7A9+6dazGb8ArZeN3PHoEQ5auWVF0KukzH9WfnJxRYyOvV3xAC9dlnABP4Bk1PYKOp7KLNLEs99sRbAer/TC9dcUChthdY8njzammZaNExPlPiHgwtXoKzNPeb7MMMsuotkYv+J1XPCdeHoPY9QG0nuYqi1RUxfAzFhfrSnCsmL/mFXFYoHI47918QCljSBhyEGGB9HPRSal5TMulTKQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Tue, 03 Dec 2024 09:26:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbRWTiS8+/Ezdwzk6UJiAaaYX4BrLUP+cA
- Thread-topic: [PATCH] bootfdt: Add missing trailing commas in BOOTINFO_{ACPI,SHMEM}_INIT
> On 3 Dec 2024, at 09:22, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Commit a14593e3995a extended BOOTINFO_{ACPI,SHMEM}_INIT initializers
> list with a new 'type' member but forgot to add trailing commas (they
> were present before). This results in a build failure when building
> with CONFIG_ACPI=y and CONFIG_STATIC_SHM=y:
> ./include/xen/bootfdt.h:155:5: error: request for member 'shmem' in something
> not a structure or union
> 155 | .shmem.common.max_banks = NR_SHMEM_BANKS, \
> | ^
> ./include/xen/bootfdt.h:168:5: note: in expansion of macro
> 'BOOTINFO_SHMEM_INIT'
> 168 | BOOTINFO_SHMEM_INIT \
> | ^~~~~~~~~~~~~~~~~~~
> common/device-tree/bootinfo.c:22:39: note: in expansion of macro
> 'BOOTINFO_INIT'
> 22 | struct bootinfo __initdata bootinfo = BOOTINFO_INIT;
>
> Fixes: a14593e3995a ("xen/device-tree: Allow region overlapping with
> /memreserve/ ranges")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
Thanks Michal, I realise our internal CI is not testing a configuration with
CONFIG_ACPI=y and
CONFIG_STATIC_SHM=y, this is why I missed it.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx
<mailto:luca.fancellu@xxxxxxx>>
Cheers,
Luca
|
