Re: [PATCH] misra: increase identifiers length to 64

[Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>]

On 2024-11-16 01:23, Stefano Stabellini wrote:
> Currently the identifiers characters limit is arbitrarily set to 40. It
> causes a few violations as we have some identifiers longer than 40.
>
> Increase the limit to another rather arbitrary limit of 64. Thanks to
> this change, we remove a few violations, getting us one step closer to
> marking Rules 5.2 and 5.4 as clean.
>
> Also update the ECLAIR config that was actually set to 63 as character
> limit.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
>
> diff --git a/automation/eclair_analysis/ECLAIR/toolchain.ecl 
> b/automation/eclair_analysis/ECLAIR/toolchain.ecl
> index 86e9a79b52..8fb1778bce 100644
> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
> @@ -155,8 +155,8 @@
>   -doc_end
>   
>   -doc_begin="See Section \"4.3 Identifiers\" of "GCC_MANUAL"."
> --config=STD.extidsig, behavior+={c99, GCC_ARM64, "63"}
> --config=STD.extidsig, behavior+={c99, GCC_X86_64, "63"}
> +-config=STD.extidsig, behavior+={c99, GCC_ARM64, "64"}
> +-config=STD.extidsig, behavior+={c99, GCC_X86_64, "64"}
>   -doc_end
>   
>   #
> diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst
> index 4a144da8d6..3ed5801bff 100644
> --- a/docs/misra/rules.rst
> +++ b/docs/misra/rules.rst
> @@ -154,7 +154,7 @@ maintainers if you want to suggest a change.
>      * - `Rule 5.1 
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_05_01_2.c>`_
>        - Required
>        - External identifiers shall be distinct
> -     - The Xen characters limit for identifiers is 40. Public headers
> +     - The Xen characters limit for identifiers is 64. Public headers
>          (xen/include/public/) are allowed to retain longer identifiers
>          for backward compatibility.
>   
> @@ -162,7 +162,7 @@ maintainers if you want to suggest a change.
>        - Required
>        - Identifiers declared in the same scope and name space shall be
>          distinct
> -     - The Xen characters limit for identifiers is 40. Public headers
> +     - The Xen characters limit for identifiers is 64. Public headers
>          (xen/include/public/) are allowed to retain longer identifiers
>          for backward compatibility.
>   
> @@ -177,7 +177,7 @@ maintainers if you want to suggest a change.
>      * - `Rule 5.4 
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_05_04.c>`_
>        - Required
>        - Macro identifiers shall be distinct
> -     - The Xen characters limit for macro identifiers is 40. Public
> +     - The Xen characters limit for macro identifiers is 64. Public
>          headers (xen/include/public/) are allowed to retain longer
>          identifiers for backward compatibility.
While for external identifiers 64 can be considered as random as 63,
for internal identifiers and macro names 63, which is what the C99
standard guarantees, is better than 64 (which is one more than the
standard guarantees).

Kind regards,

   Roberto