[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/10] x86/ucode: Fold early_update_cache() into its single caller
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Sat, 2 Nov 2024 13:15:38 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1730567742; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=X/1eYTu5iCclYZG5/QUy7XmL1x0wKedDmLPIgk5btTM=; b=geNXYWpswKuc6OKbMY2JZ5N9+i9UgOP7h/KuqwRQhlXJ8IQAewh1Wf8wZhitgAbSGu5y53fuy9V5WKYM/4Uw+fAdz9w3fY0KxhvsomjKw3d+cC3ipqs9DiEyZfEXHOe9df2Z9sNmBMAZyWr/uBmlmV7osw2t4L5qGW/bUhIsJdg=
- Arc-seal: i=1; a=rsa-sha256; t=1730567742; cv=none; d=zohomail.com; s=zohoarc; b=l6FXH4SD2BCbR/Mky2ny7yVYQ+muQzxn19b5hhep1hT59y24aLgO7jxJnt/pOibP20uMjENy3wcSVd9vT+zsj9rjFdaSR2SDKU4MzI6lS6AYWmMb0E2eAocbu/Gz3C6+gdr2yhXLIGtZo6pwwKBS8CJ/49tFJympbbyNvPBEJl4=
- Cc: Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Sat, 02 Nov 2024 17:15:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/28/24 05:18, Andrew Cooper wrote:
The data pointer is known good, so the -ENOMEM path is unnecessary. However,
if we find no patch, something's wrong seeing as early_microcode_init()
indicated it was happy.
We are the entity initialising the cache, so we don't need the complexity of
using microcode_update_cache(). Just assert the cache is empty, and populate
it.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---
Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
|
