[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 12/14] x86/fpu: Pass explicit xsave areas to fpu_(f)xsave()
On Tue Oct 29, 2024 at 8:37 AM GMT, Jan Beulich wrote: > On 28.10.2024 16:49, Alejandro Vallejo wrote: > > --- a/xen/arch/x86/xstate.c > > +++ b/xen/arch/x86/xstate.c > > @@ -300,9 +300,8 @@ void compress_xsave_states(struct vcpu *v, const void > > *src, unsigned int size) > > vcpu_unmap_xsave_area(v, xstate); > > } > > > > -void xsave(struct vcpu *v, uint64_t mask) > > +void xsave(struct vcpu *v, struct xsave_struct *ptr, uint64_t mask) > > { > > - struct xsave_struct *ptr = v->arch.xsave_area; > > uint32_t hmask = mask >> 32; > > uint32_t lmask = mask; > > unsigned int fip_width = v->domain->arch.x87_fip_width; > > Imo this change wants to constify v at the same time, to demonstrate that > nothing is changed through v anymore. The comment may extend to other > functions > as well that are being altered here; I only closely looks at this one. > > Jan I didn't think of that angle... I'll have a look and take it into account for v2. Cheers, Alejandro
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |