[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/3] x86/boot: Remove the mbi_p parameter from __start_xen()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 23 Oct 2024 10:58:37 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1729695520; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=XFUZApqXLzTPG9d+X1HRSKAJr1RKWKgKuddXGS32uXs=; b=isTt/VFm4RkrDm3I+wL95R4LisSErSEcYIbVd7vpJ0GNuNTmDQelk0LH6Pzb+xwJzaocjKHu4sAMwt9RxcfvviKlvmhm6Vobu+lxenhtslV+0ELI6FZS5qoGoAwQ82SUyaTbl7C55K4+L9v1vo52cQixQHCRKnmDtSbMRlZ//oY=
- Arc-seal: i=1; a=rsa-sha256; t=1729695520; cv=none; d=zohomail.com; s=zohoarc; b=JoOjLytBV0xD7ZnknejYKoQX+Os6TYXkWxxoO9zi+TapP0IgoN0h+P07+vqxN7BAGVEB9bmQV+4sk8A41XdJl06DD9tc8XeV1bLjSmWVT3b8Q4Niqmz4xHYnMN8evzZqbYbLJiSdc8yYrPLJ2VSq/uNV6Mi7UfwXMqG8+s74QHI=
- Cc: Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 23 Oct 2024 14:58:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/23/24 10:44, Andrew Cooper wrote:
The use of physical addresses in __start_xen() has proved to be fertile soure
of bugs.
The MB1/2 path stashes the MBI pointer in multiboot_ptr (a setup.c variable
even), then re-loads it immediately before calling __start_xen(). For this,
we can just drop the function parameter and read multiboot_ptr in the one
place it's used.
The EFI path also passes this parameter into __start_xen(). Have the EFI path
set up multiboot_ptr too, and move the explanation of phyiscal-mode pointers.
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
CC: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
For EFI:
Acked-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
For remainder:
Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
|
