Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

[Frediano Ziglio <frediano.ziglio@xxxxxxxxx>]

On Thu, Oct 17, 2024 at 5:00 PM Anthony PERARD
<anthony.perard@xxxxxxxxxx> wrote:
>
> On Thu, Oct 17, 2024 at 02:31:19PM +0100, Frediano Ziglio wrote:
> > +$(obj)/build32.base.lds: AFLAGS-y += -DGAP=$(text_gap) 
> > -DTEXT_DIFF=$(text_diff)
> > +$(obj)/build32.offset.lds: AFLAGS-y += -DGAP=$(text_gap) 
> > -DTEXT_DIFF=$(text_diff) -DFINAL
>
> I was somehow expecting "base" and "offset" to be the other way around,

That's weird. I mean, the "base" uses a GAP and TEXT_START of 0 while
for "offset" they are not zero adding some offset to the code/data.

> but that's fine. And by the way, -DFINAL cancel changes to GAP and
> TEXT_DIFF ;-).
>

Yes, and potentially the first like added above can be removed. On the
other hand, they are values used for the algorithm despite them being
used in some cases or not.

> But overall, the changes looks nice as is,
> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>
> Thanks,
>
Thanks,

Frediano