Re: [XEN PATCH v1 2/3] ocaml/libs: Fill build failure due to unused variable in ocaml macro

[Christian Lindig <christian.lindig@xxxxxxxxx>]

> On 17 Oct 2024, at 18:47, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> 
> 
> So, I think this is a better fix:
> 
> @@ -69,6 +69,7 @@ static void Noreturn xsd_glue_failwith(
>         free(str);
>  
>         caml_raise_with_arg(*caml_named_value("xsg.error_v1"), msg);
> +       CAMLnoreturn;
>  }
>  #define xsd_glue_failwith(xch) xsd_glue_failwith(xch, __func__, __LINE__)
>  
> and F40 seem happy with the result.

Acked-by: Christian Lindig <christian.lindig@xxxxxxxxx>


I like the effort to remove warnings.

— C