[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 11/44] x86/boot: add start and size fields to struct boot_module


  • To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Thu, 17 Oct 2024 19:12:59 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xB+CrNJ2+x2Ays8w4baPV6mTqog/lvZm6DwxS8oVzVo=; b=fnL0osKip2gUPfE+ll+q4xN9w3W9JknBpMPatWkz9zBuoBmclMqVkyJhaeovzUxMomvkUqdIGxT7ThZWcWzCygh9G50imWZoSr4QDIJlaL5pNeXhG8cQIEqp0qHazsHdZA0KqkoOPHcM2GCaVLRjOBAE8kLioObyuanIvyWWGmMRmeRQW2f0aYg7riOSiY21ziAIIB5A33FcSU7yd7B+Vl6NIqOIwIATBE5iL5WlfFP/n1t2QU9/6nNy1D8CK7+wnfcIrirdomohsP+34P72S4jqkEop3h+kWGtEKA/TEDTOaWBY17hNfF6EXoQXaIfdPjI8vLg7VKf3ZdlOPmX8ag==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vcD1VtBkpy/NBooz7xa+w9Zbv752m0TOQdAn9e9T9cEuv3hlD7GTzHCmF/CuOnfRrSpm7I1ROfMjYTZHMSFXt3ZFtu9tPQrHScYGsIY4rGxQler0fnJmfXeTq1ZHAoewkR6SxL99JrGicK3+LNF/8xQ5+IQV/PJjdHAxt7DzANoBQpRaQwGKcziDFFZBd5zIKnQo2bmZrbJPzrxXgJnx0bYPDDT8WlUIWGw9TuMw6F9hDx01v8pFaZ69ooHCjg0C2gdJ06RhB/cupDGaIS+X3qxAATS6nDXSS9Z1x6aFddS4lbDnr7F5eSpIHf6lsrt2Ed0hFg30am3xbG2fX12GpA==
  • Cc: <christopher.w.clark@xxxxxxxxx>, <stefano.stabellini@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Thu, 17 Oct 2024 23:13:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2024-10-17 13:02, Daniel P. Smith wrote:
This commit introduces the start and size fields to struct boot_module and
assigns their value during boot_info construction.

The EFI entry point special cased itself, and pre-converted mod_start and
mod_end to mfn and size respectively. This required an additional test
in the coversion loop to not convert mod_start and mod_end when the conversion

conversion

was done for both the multiboot and PVH boot entry points. To simplify the
logic populating the start and size fields, the EFI module population logic
was coverted to using start and end addresses.

converted


Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>

with that
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

EFI now gains the alignment check, but beforehand it was just silently truncating. Seems better to check :)

Regards,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.