[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/6] xen/arm: mpu: Introduce choice between MMU and MPU
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 14 Oct 2024 18:43:53 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KWx7wan0tT2TaXJIvMp6T6BMjmqGnLSD2Ljm8vf2WIo=; b=Wp5G+n0wUGKx6JazSTzEF7Dagtm1gm9rU2OJk9/dOCav5OPk13NP18DhLqt3YoPdbYqrj7HX2qeLh8GyHJNVGYiwsPDnFTkUcDMHn6g4F0Vgv43IQpzN2TiNcE4M1Ro9I7pMsAGeCTqYZ+7Ns/i5DL0Gjhbn8M6DnU4YTLZ3+BHjtBp5K/Vnv/gWswvwUy7dtHYzmM4Rvi14HI7od1EUIOhZIEhmJqbDQmZOPVHxez28Iy1jaHNQv8jSW/FTuGSF9+gTm8WvzvcCn+8DjwQDfZr46dyNLq/lam0PKVUsBNTQu47o4FF7BFK6KmGuK3L7M7ZVESvF2OPvdhemU/PSCg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KWx7wan0tT2TaXJIvMp6T6BMjmqGnLSD2Ljm8vf2WIo=; b=vwz4flxE6BzY5xOhIjqddqomV2igind+DQIN1XJRoHzhEnCzCQRO8w7qmQwWlrbCvQUvufjj++jburWJ+XhNp/g7mttL9intnPrggePQTmapa3bFT1D0fM+58LMQaroC20jtlsycYJx1IPX7WmjkSZmnlfg4eWZcgWGuUXJorT0gqfB8cuQcgY4L9IeYZHGtoUxWzwCgvdKrAtm+N7+hmr8z4rHztDW/AN0HPT6eUfJvTn3nf8HXArSfZgEBkABIXAz0rUEZYSo4WE5AJ8av6SzWmN7cmMJCcEViAQJmcyGyjQNvmy+Ov2w4xXWiWqWFy2zHyRBseCel+nn0V6JYaw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=nAK36BNlY3J9Mk7JA0fWbxtKhE4wUErsYyLKj7TGlDnbbqzLQKLeaHRVUwAxJpLav+cN+NCdq2IZu7UvBXvLQ//6hvpvckOhJvxfDSWMrCAlXDwtfmkHejRYwPgnsVixRlJsVdYtLtZ6ygb+jOkA4sinjdfnmyv1JyUUofE7VcIWSSVxP5R+cygcGTi6esjIKD5kQ602XZxQAcVjzlB19OSIquUmhtwLnkSafWiPArIUfw39CQrBj70rkXXlRSvR2oE9QGf0/wMlksSEMMWDGQ61vRreBaRZetoMqTkgvLl4lC1HjiNugy+/QXfpKJu3iKbHof8A5DyjkN8dOgOIZA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MpFgAt9ozklkN5tiLoeLo5SdL1xhHWM9OITnQxmvWU2lLQfbZuY9TrVwKb0jvda2d0sjar98uCnv6iV2wrqKIHtbH0ezFlMsllMGrA2T3pWibm0W5CbocvWEDMRMTkeb2w8Qx5WhovLxtzcyS0IZCtxRbCSgK1A6EgqplEPZsFh8+ZsGzthnTuhGFUPgqtlmLDIDcRUrA3lgt/0IDMbuMzm0qLqYRDIE3q7VDtAPw1Fb09nh3KJTf69iedLxbHGF7cWxqYCa0SV1pTzm+YgMTzoFfhTLBXraLeM/3Uv9HcBG/Nnz5RQqTbydnNIrvkBwt/aopKJC4+LaTRNtmTuSxA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 14 Oct 2024 18:44:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHbGx127FMt5Y9y2EO8VFlcKfnxirKGm8AA
- Thread-topic: [PATCH v3 2/6] xen/arm: mpu: Introduce choice between MMU and MPU
Hi Ayan,
> On 10 Oct 2024, at 15:03, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> wrote:
>
> There are features in the forthcoming patches which are dependent on
> MPU. For eg fixed start address.
> Also, some of the Xen features (eg STATIC_MEMORY) will be selected
> by the MPU configuration.
>
> Thus, this patch introduces a choice between MMU and MPU for the type
> of memory management system. By default, MMU is selected.
> MPU is now gated by UNSUPPORTED.
>
> Update SUPPORT.md to state that the support for MPU is experimental.
Maybe I’m wrong, but shouldn’t we add this only when MPU is supported?
In this case we are just having the Kconfig setting.
Apart from that, the rest looks good to me:
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|