[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 05/44] x86/boot: introduce struct boot_module


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Wed, 9 Oct 2024 21:01:49 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728522112; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=8It+sKe1bOr1v4FAbbm/h6qlDH9jGu7Ukb0srMyWRhI=; b=GiL5usWGHMR5hY4gQ6Bk3JzlUB41Wurw7vo3//IAbY7CJzIFTulJ/aa14Y0MehJv6UEf7OZ50v0JUn24VRd9sWIyVUyewoThqd/MYg33KV2LFFZGkVhezOnv+j+fZkTAEm8VaIrS6UYv2sWWyB3eZj3deZyF9VFGMxK1a63p6P8=
  • Arc-seal: i=1; a=rsa-sha256; t=1728522112; cv=none; d=zohomail.com; s=zohoarc; b=Dv56mP/+DKLa8/YjDIWyWo1TleCfbT9P22sIsK7AIFWV76MlhbI2Qx95bhHUY15m99Fx16hoIKqRRFGNp7jaSkBs8uW6DCpm/6Ry3B9HPp7TQQAUnmmK7cYQ2xrSemMqXTCRbLwDNGVglHANJcbdZkNneqZ9oDhA761IADwr0K8=
  • Cc: jason.andryuk@xxxxxxx, christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 10 Oct 2024 01:02:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10/9/24 11:17, Jan Beulich wrote:
On 06.10.2024 23:49, Daniel P. Smith wrote:
@@ -302,6 +304,13 @@ static struct boot_info __init 
*multiboot_fill_boot_info(unsigned long mbi_p)
          bi->memmap_length = mbi->mmap_length;
      }
+ /*
+     * This will iterate over all modules to include an extra mb module, which
+     * should have been reserved to hold an entry for Xen.
+     */
+    for ( i = 0; i <= bi->nr_modules; i++ )
+        bi->mods[i].mod = &mods[i];

I find the comment difficult to follow / match with code here and elsewhere.
How about "Iterate over all modules, including the extra one which should
have been reserved for Xen itself"?

Okay.

v/r,
dps



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.