Re: [PATCH v5 44/44] x86/boot: convert dom0_construct_pvh to struct boot_domain

["Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>]

On 10/8/24 15:56, Jason Andryuk wrote:
> On 2024-10-06 17:49, Daniel P. Smith wrote:
> > With construct_dom0 consuming struct boot_domain, continue passing the
> > structure down to dom0_construct_pvh.
> >
> > Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
> > diff --git a/xen/arch/x86/hvm/dom0_build.c 
> > b/xen/arch/x86/hvm/dom0_build.c
> > index a3fd5e762dc4..755e257cdf30 100644
> > --- a/xen/arch/x86/hvm/dom0_build.c
> > +++ b/xen/arch/x86/hvm/dom0_build.c
> > @@ -1299,25 +1299,23 @@ static void __hwdom_init 
> > pvh_setup_mmcfg(struct domain *d)
> >       }
> >   }
> > -int __init dom0_construct_pvh(
> > -    struct domain *d, const struct boot_module *image,
> > -    struct boot_module *initrd, const char *cmdline)
> > +int __init dom0_construct_pvh(const struct boot_domain *bd)
> >   {
> >       paddr_t entry, start_info;
> >       int rc;
> Again, I recommend using a local struct domain *d to cut down on the churn.
Ack.

v/r,
dps