[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 39/44] x86/boot: introduce domid field to struct boot_domain
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 9 Oct 2024 20:34:34 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728520478; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=3hotaApiG9nEtD5X/rHFSRzsivuL7l4e6M0/lJhnYqc=; b=LOHmYf0lr1Xlp4APK5VZXMQiwH+KBXUlcX7TtP5ArsPJkmeSeRDLZybT+dm3GK5OSyvZ9Wp6ENfR3rAa8BrEJkojxxRN08BQWFUCsshM/vyFZcbyGfRDyrRKMJCey2cePBoha+2RuotNKh3G0f0xdkush+eF4NsFT/k6FHrAk6w=
- Arc-seal: i=1; a=rsa-sha256; t=1728520478; cv=none; d=zohomail.com; s=zohoarc; b=LW9PE7SW2HpylCqSfGAH6M2kAAfXSU1pHkXgx08Qk8v17Ie8DzZHkUoS4GwqRTdX3hG5LP/uhjDYUUxIO/O95Knx+FpRNsKwV8vRbm56VePcij5N5oIuaXVPcOC85vy8w4YLvKATcMHaEWyuCONNGMtbMT1Q9qaPd4/HoVNrAFI=
- Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 10 Oct 2024 00:34:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/8/24 15:36, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
Add a domid field to struct boot_domain to hold the assigned domain id
for the
domain. During initialization, ensure all instances of struct
boot_domain have
the invalid domid to ensure that the domid must be set either by
convention or
configuration.
Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---
xen/arch/x86/include/asm/bootdomain.h | 2 ++
xen/arch/x86/setup.c | 12 +++++++-----
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/xen/arch/x86/include/asm/bootdomain.h
b/xen/arch/x86/include/asm/bootdomain.h
index 4285223ac5ab..d6264d554dba 100644
--- a/xen/arch/x86/include/asm/bootdomain.h
+++ b/xen/arch/x86/include/asm/bootdomain.h
@@ -11,6 +11,8 @@
struct boot_module;
struct boot_domain {
+ domid_t domid;
+
struct boot_module *kernel;
struct boot_module *ramdisk;
};
Oh, you should probably move domid after the pointers to avoid a hole.
It's not a packed structure and at this point, we are not looking to
make it an ABI. If the maintainers think there is a real concern here,
then I can add a reserved field to fill the hole.
v/r,
dps
|
