[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 30/44] x86/boot: convert dom0_construct_pv initrd param to struct boot_module


  • To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Wed, 9 Oct 2024 19:12:21 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728515545; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=CRjgCxYHOQlWMv2xwQkbSVWeOeTMUyHT68y+ZkZVLXI=; b=GFTes7zVLF3+gANJ8liJybGWmMI0VEftMKw2q3erQI1T3F/GwpeD54H+m/TIPURHfOQGteAhwIA47URAyqQaonxi3ypmbqVTIiqhZA/FK3d0/ugBQ3hy1eF0BreEsxF/o1Q43glBPb9I7yUoqPp1U1KpZzu/ja6ZY9XAnupLe1c=
  • Arc-seal: i=1; a=rsa-sha256; t=1728515545; cv=none; d=zohomail.com; s=zohoarc; b=iHCysmOxMuXFYTpekrpDgjvqyctxxiZ+aBlc3qxP2Yk+Hb6Xk7HdXZ6P1hoyIHwmdYOdDZ2HLiY7CJ1AiD/hhu2hoUSf3nZfF3ApxXx0ww5PujISzL01HoI+h0x8SXAkO+GwS0amHe5MkOOEk0ZPfo9VdiEw84bqMkEzIVmU3FM=
  • Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 09 Oct 2024 23:12:33 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10/8/24 14:30, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
This changes the type for the initrd parameter of dom0_construct_pv to be struct boot_module. This conversion requires several adjustments throughout dom0_construct_pv to account for the type change. Removes the usage of early_mod field for ramdisk module.

Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>

diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c
index 7b6afe64d799..16b8c1e40998 100644
--- a/xen/arch/x86/pv/dom0_build.c
+++ b/xen/arch/x86/pv/dom0_build.c

@@ -367,7 +367,8 @@ static int __init dom0_construct(struct domain *d,
      unsigned long nr_pt_pages;
      unsigned long alloc_spfn;
      unsigned long alloc_epfn;
-    unsigned long initrd_pfn = -1, initrd_mfn = 0;
+    unsigned long initrd_pfn = -1;
+    mfn_t  initrd_mfn = { 0 };

= _mfn(0);

Ack.

With that:

Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Thanks!

v/r,
dps



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.