[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 17/44] x86/boot: convert microcode loading to consume struct boot_info
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Wed, 9 Oct 2024 10:57:48 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728485871; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=yd5LR/WM4MKlk292ehbFESZEYtQGV2oyGSCyoeT4no8=; b=nJ+RgB0NfgmEEeTrMTi521mubYBGaBotaStYFk0BfmccoVW2wrel2l+k7L7tmLQQjb2R+wq9kufG3GgTnNUU+QDD7eHQ/6IaIqnEBmtxgL0m7JHKDhu4gSFRZ7RX968+nr2cifQ1YOtxBVjurpgTggyob1khvCRkpDWH4+aOQtg=
- Arc-seal: i=1; a=rsa-sha256; t=1728485871; cv=none; d=zohomail.com; s=zohoarc; b=eF86tbeE50LvyDGjsfAo2cxZWHb2OCh6vQfmWnncqsfnvHppkGb/GkKC+BHxOx9yboehNtfdZGptOcgS8kgJv1zNViNm2uGr5SecgMyt9y28KHFMD6zLd+Yc4x5duK1rVpqlNTmUYqxdIYaYTydbGD1Nz0VhoOC15r9/6G0wXfw=
- Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 09 Oct 2024 14:58:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/7/24 17:22, Jason Andryuk wrote:
@@ -822,8 +819,8 @@ static int __init early_update_cache(const void
*data, size_t len)
return rc;
}
-int __init microcode_init_cache(unsigned long *module_map,
- const struct multiboot_info *mbi)
+int __init microcode_init_cache(
+ unsigned long *module_map, const struct boot_info *bi)
Why the indent style change? I prefer the original indent and it
doesn't seem like the line length matters. And it looks like you
restore the indent later.
This is one I missed unrolling earlier version. Originally was applying
the style requested but then realized it was unnecessary churn as by the
end of the series the only param would be *bi and was waiting until the
last change to move to requested format.
|
