[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 03/44] x86/boot: move cmdline to boot info


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>
  • From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Date: Wed, 9 Oct 2024 07:28:08 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728473291; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=cQnkfH27S40SgWUUv2Zh0VqoE9tFT41RK/y4GBXUTiU=; b=Kq9zuz8jIC/qOmAkE87/3JCREn9e7LbnWGC5VrkX4tEafafSzKOUH1J8cfUHwXa9fY2kXbmIw6SNs8ipbN4sRnC3BzAY58FtGjlmGz6KY4Lpl6Lbv59aArGBzxTCZUArpeaplAQL7m68H2Vcp26wPkm+jvf+K3guWCjigPwZZfE=
  • Arc-seal: i=1; a=rsa-sha256; t=1728473291; cv=none; d=zohomail.com; s=zohoarc; b=b9rbYzIWB0FK/3ke1XqQ7G4XyNSCtOf8DuyRx2xaSZSBht42ueEmi3Wx5JJhWnuiNgr9cpmRjcLiazVU3G6C+Oum7BSZDTlUXW22KmYCyurMLwk7eq9uNO1VLXFr/E3ojrGVjt2yByuzkZ0pHm+jcKptMmPpBFz4UQcCDKWamBw=
  • Cc: christopher.w.clark@xxxxxxxxx, stefano.stabellini@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 09 Oct 2024 11:28:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10/8/24 02:42, Jan Beulich wrote:
On 07.10.2024 20:09, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
Transition Xen's command line to being held in struct boot_info.

No functional change intended.

Signed-off-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---

   #endif /* __XEN_X86_BOOTINFO_H__ */
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index aafc098ca268..0921f296075f 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -274,6 +274,8 @@ static int __init cf_check parse_acpi_param(const char *s)
   }
   custom_param("acpi", parse_acpi_param);
+static const char *cmdline_cook(const char *p, const char *loader_name);

Is there a reason not to move cmdline_cook() (and loader_is_grub2())
earlier to avoid this forward declaration?

At a guess: To limit churn?

Correct.

v/r,
dps



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.