[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v4 2/2] x86/fpu: Rework fpu_setup_fpu() uses to split it in two
On Tue Oct 8, 2024 at 7:37 AM BST, Jan Beulich wrote: > On 07.10.2024 17:52, Alejandro Vallejo wrote: > > It was trying to do too many things at once and there was no clear way of > > defining what it was meant to do. This commit splits the function in two. > > > > 1. A function to return the FPU to power-on reset values. > > 2. A x87/SSE state loader (equivalent to the old function when it took > > a data pointer). > > > > The old function also had a concept of "default" values that the FPU > > would be configured for in some cases but not others. This patch removes > > that 3rd vague initial state and replaces it with power-on reset. > > > > While doing this make sure the abridged control tag is consistent with the > > manuals and starts as 0xFF > > > > Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx> > > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> > > -- > > @Jan: The patch changed substantially. Are you still ok with this R-by? > > I am. However in such a situation imo you'd better drop the tag, for it to > be re-offered (if desired). It can very well happen that the person simply > doesn't notice the question pointed at them. > > Jan Noted for next time. Thanks for the promptness! Cheers, Alejandro
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |